Skip to content

Add missing unit test for resource resize policy defaulting #116684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 17, 2023
Merged

Add missing unit test for resource resize policy defaulting #116684

merged 3 commits into from
Mar 17, 2023

Conversation

@vinaykul
Copy link
Member

@vinaykul vinaykul commented Mar 16, 2023 •
edited
Loading

What type of PR is this?

/kind cleanup

What this PR does / why we need it: This PR adds a missed unit test for PR #116119 that added resize policy defaulting for pod resource in-place resize feature.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change? no

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

/assign @thockin

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Mar 16, 2023
@k8s-ci-robot k8s-ci-robot requested review from ncdc and tallclair March 16, 2023 13:52
@k8s-ci-robot k8s-ci-robot added sig/apps Categorizes an issue or PR as relevant to SIG Apps. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 16, 2023
@vinaykul
Copy link
Member Author

vinaykul commented Mar 16, 2023

/sig node
/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Mar 16, 2023
This was referenced Mar 16, 2023
Merged
Open
@SergeyKanzhelev
Copy link
Member

SergeyKanzhelev commented Mar 16, 2023

/milestone v1.27

@k8s-ci-robot k8s-ci-robot added this to the v1.27 milestone Mar 16, 2023
@SergeyKanzhelev
Copy link
Member

SergeyKanzhelev commented Mar 16, 2023

/triage accepted
/priority important-soon

this is a test-only follow up for KEP with approved exception request

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Mar 16, 2023
SergeyKanzhelev
SergeyKanzhelev reviewed Mar 16, 2023
View reviewed changes
pkg/apis/core/v1/defaults_test.go Outdated
Copy link
Member

@SergeyKanzhelev SergeyKanzhelev Mar 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add a test for some other resource name other than memory and CPU

Copy link
Member Author

@vinaykul vinaykul Mar 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added ephemeral storage resource in a few different combinations. Please review.

SergeyKanzhelev
SergeyKanzhelev approved these changes Mar 16, 2023
View reviewed changes
Copy link
Member

@SergeyKanzhelev SergeyKanzhelev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 16, 2023
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Mar 16, 2023

LGTM label has been added.

Git tree hash: 3e2358537d09692383f5efb959475db2c73b38a8

@k8s-ci-robot k8s-ci-robot added area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. labels Mar 17, 2023
@vinaykul vinaykul force-pushed the restart-free-pod-vertical-scaling-fixes branch 2 times, most recently from b39830c to cb94405 Compare March 17, 2023 03:42
@vinaykul
Copy link
Member Author

vinaykul commented Mar 17, 2023

/assign @sftim
Please review changelog, thanks.

@vinaykul
Copy link
Member Author

vinaykul commented Mar 17, 2023

/assign @pacoxu

@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 17, 2023
@vinaykul
Copy link
Member Author

vinaykul commented Mar 17, 2023

/assign @ramrodo

@SergeyKanzhelev
Copy link
Member

SergeyKanzhelev commented Mar 17, 2023

Were api/openapi-spec/swagger.json and api/openapi-spec/v3/apis__storage.k8s.io__v1beta1_openapi.json picked up by mistake?

Changelog and unit tests lgtm

@vinaykul
Copy link
Member Author

vinaykul commented Mar 17, 2023

Were api/openapi-spec/swagger.json and api/openapi-spec/v3/apis__storage.k8s.io__v1beta1_openapi.json picked up by mistake?

Changelog and unit tests lgtm

k8s-verify job failed and failure logs asked to run update-openapi-spec. https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/116684/pull-kubernetes-verify/1636573699786149888

It is unrelated to my changes but without it CI blocks the PR.

pacoxu
pacoxu reviewed Mar 17, 2023
View reviewed changes
api/openapi-spec/swagger.json Outdated
Copy link
Member

@pacoxu pacoxu Mar 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fixed in #116705 and you may wait for that change to be merged and rebase with the latest code later.

Copy link
Member Author

@vinaykul vinaykul Mar 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rebased and updated, thanks.

@vinaykul vinaykul force-pushed the restart-free-pod-vertical-scaling-fixes branch from 9976b5a to 0c2c132 Compare March 17, 2023 08:53
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 17, 2023
thockin
thockin reviewed Mar 17, 2023
View reviewed changes
Copy link
Member

@thockin thockin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 17, 2023
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Mar 17, 2023

LGTM label has been added.

Git tree hash: ff5312b5b13e16dbbe45274f857e3db9824b338c

@xmudrii
Copy link
Member

xmudrii commented Mar 17, 2023

/approve

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Mar 17, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SergeyKanzhelev, thockin, vinaykul, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 17, 2023
@k8s-ci-robot k8s-ci-robot merged commit c14e098 into kubernetes:master Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thockin thockin thockin left review comments

@ncdc ncdc Awaiting requested review from ncdc

@tallclair tallclair Awaiting requested review from tallclair

@mrunalp mrunalp Awaiting requested review from mrunalp

@SergeyKanzhelev SergeyKanzhelev Awaiting requested review from SergeyKanzhelev

+1 more reviewer

@pacoxu pacoxu pacoxu left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@mrunalp mrunalp

@pacoxu pacoxu

@ramrodo ramrodo

@thockin thockin

@SergeyKanzhelev SergeyKanzhelev

@sftim sftim

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/release Categorizes an issue or PR as relevant to SIG Release. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Projects

[sig-release] Bug Triage
Archived in project

Milestone

v1.27

Development

Successfully merging this pull request may close these issues.

9 participants

@vinaykul @SergeyKanzhelev @k8s-ci-robot @xmudrii @pacoxu @thockin @mrunalp @ramrodo @sftim