Skip to content

[KEP-3751] Promote VolumeAttributesClass to beta #126145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 23, 2024
Merged

[KEP-3751] Promote VolumeAttributesClass to beta #126145

merged 1 commit into from
Jul 23, 2024

Conversation

@carlory
Copy link
Member

@carlory carlory commented Jul 17, 2024 •
edited
Loading

What type of PR is this?

/kind feature
/kind api-change

What this PR does / why we need it:

Promotes the VolumeAttributesClass to beta

Beta graduation criteria:

Which issue(s) this PR fixes:

Part of kubernetes/enhancements#3751

Special notes for your reviewer:

/hold

util Beta graduation criteria is met

Does this PR introduce a user-facing change?

- Promoted feature-gate `VolumeAttributesClass` to beta (disabled by default). Users need to enable the feature gate and the storage v1beta1 group to use this new feature.
- Promoted API `VolumeAttributesClass` and `VolumeAttributesClassList` to `storage.k8s.io/v1beta1`.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]:  https://github.com/kubernetes/enhancements/issues/3751

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/feature Categorizes issue or PR as related to a new feature. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/code-generation area/kubectl area/test sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/etcd Categorizes an issue or PR as relevant to SIG Etcd. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jul 17, 2024
@k8s-ci-robot k8s-ci-robot requested review from aojea and ardaguclu July 17, 2024 08:21
@carlory
Copy link
Member Author

carlory commented Jul 17, 2024

/cc @msau42 @xing-yang @mattcary @ConnorJC3

@k8s-ci-robot k8s-ci-robot added the sig/apps Categorizes an issue or PR as relevant to SIG Apps. label Jul 17, 2024
@carlory carlory changed the title Promote VolumeAttributesClass to beta [KEP-3751] Promote VolumeAttributesClass to beta Jul 17, 2024
@carlory carlory mentioned this pull request Jul 17, 2024
Merged
@carlory
Copy link
Member Author

carlory commented Jul 22, 2024

/test pull-kubernetes-e2e-storage-kind-alpha-beta-features

@msau42
Copy link
Member

msau42 commented Jul 22, 2024

/test pull-kubernetes-e2e-storage-kind-alpha-beta-features

@carlory
Copy link
Member Author

carlory commented Jul 23, 2024

/test pull-kubernetes-e2e-storage-kind-alpha-beta-features

@carlory
Copy link
Member Author

carlory commented Jul 23, 2024

/test pull-kubernetes-e2e-storage-kind-alpha-beta-features

1 similar comment
@carlory
Copy link
Member Author

carlory commented Jul 23, 2024

/test pull-kubernetes-e2e-storage-kind-alpha-beta-features

@msau42
Copy link
Member

msau42 commented Jul 23, 2024

#121902 is expected to address the test failure.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 23, 2024
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jul 23, 2024

LGTM label has been added.

Git tree hash: 53802ae80d5171875c3b463959085f337303ad64

@AndrewSirenko
Copy link
Contributor

AndrewSirenko commented Jul 23, 2024

/test pull-kubernetes-e2e-storage-kind-alpha-beta-features

@jpbetz
Copy link
Contributor

jpbetz commented Jul 23, 2024 •
edited
Loading

/approve
For SIG API Machinery for pkg/kubeapiserver and generated client, which is for files that should probably be owned by api-review in the future (follow up)

@xing-yang xing-yang mentioned this pull request Jul 23, 2024
Open
27 tasks
@seans3
Copy link
Contributor

seans3 commented Jul 23, 2024 •
edited
Loading

/lgtm
/approve for the small "describe" and "printers" change.

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jul 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: carlory, jpbetz, msau42, seans3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 23, 2024
@msau42
Copy link
Member

msau42 commented Jul 23, 2024

/milestone v1.31

@k8s-ci-robot k8s-ci-robot added this to the v1.31 milestone Jul 23, 2024
@carlory
Copy link
Member Author

carlory commented Jul 23, 2024

/hold cancel

Beta graduation criteria are met

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 23, 2024
@k8s-triage-robot
Copy link

k8s-triage-robot commented Jul 23, 2024

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@fedebongio
Copy link
Contributor

fedebongio commented Jul 23, 2024

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jul 23, 2024
@k8s-ci-robot k8s-ci-robot merged commit c2fdeca into kubernetes:master Jul 23, 2024
@carlory carlory deleted the kep-3751-api branch July 23, 2024 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aojea aojea Awaiting requested review from aojea

@ardaguclu ardaguclu Awaiting requested review from ardaguclu

@ConnorJC3 ConnorJC3 Awaiting requested review from ConnorJC3

@mattcary mattcary Awaiting requested review from mattcary

@msau42 msau42 Awaiting requested review from msau42

@xing-yang xing-yang Awaiting requested review from xing-yang

Assignees

@seans3 seans3

@msau42 msau42

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/code-generation area/kubectl area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/etcd Categorizes an issue or PR as relevant to SIG Etcd. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Projects

SIG Apps
Archived in project
SIG CLI
Archived in project

Milestone

v1.31

Development

Successfully merging this pull request may close these issues.

9 participants

@carlory @cici37 @msau42 @k8s-ci-robot @AndrewSirenko @jpbetz @seans3 @k8s-triage-robot @fedebongio