The committers listed above are authorized under a signed CLA.

• ✅ login: disc / name: Alexandr Hacicheant (0636ce8, 575eb55)

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Welcome @disc!

It looks like this is your first PR to kubernetes/kubernetes 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kubernetes has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

Hi @disc. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

/sig priority/important-soon

@disc: The label(s) sig/priority/important-soon cannot be applied, because the repository doesn't have them.

/priority important-soon

@mouuii: changing LGTM is restricted to collaborators

@disc you can find some one to review your code

@disc you can find some one to review your code

@mouuii how cam I do this? I see that 2 reviewers have already been selected.

/assign @mouuii

/cc @mouuii

@disc: GitHub didn't allow me to request PR reviews from the following users: mouuii.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

/assign @sttts

/unassign @mouuii

/assign @smarterclayton

Sgtm, but needs somebody from @kubernetes/api-reviewers.

/ok-to-test

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: disc
Once this PR has been reviewed and has the lgtm label, please ask for approval from smarterclayton. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Please fix relnotes:

Fox of a nil pointer dereference if gracePeriod is nil

Fix a nil pointer dereference in api server when gracePeriod was set to nil.

/lgtm

LGTM label has been added.

Please fix relnotes:

Fox of a nil pointer dereference if gracePeriod is nil

Fix a nil pointer dereference in api server when gracePeriod was set to nil.

/lgtm

Fixed

lgtm

PR needs rebase.

Looks like the issue has been fixed in another PR #127094, and my PR is no longer relevant.