[FG:InPlacePodVerticalScaling] Gate Disallow in-place resize for guaranteed pods on nodes with a static topology policy #128287

esotsal · 2024-10-23T12:31:13Z

What type of PR is this?

What this PR does / why we need it:

We want to introduce a new feature gate to allow resize for guaranteed pods with integer CPU requests on nodes with a static topology policy to unblock development on #127262.

New gate "InPlacePodVerticalScalingExclusiveCPUs" is off by default, but can be enabled to unblock development of Static CPU management alongside InPlacePodVerticalScaling.

Which issue(s) this PR fixes:

Update: Attempt to fix #128068

Special notes for your reviewer:

Does this PR introduce a user-facing change?

- Ensure resizing for Guaranteed pods with integer CPU requests on nodes with static CPU & Memory policy configured is not allowed for the beta release of in-place resize. The feature gate `InPlacePodVerticalScalingExclusiveCPUs` defaults to `false`, but can be enabled to unblock development on ([#127262](https://github.com/kubernetes/kubernetes/issues/127262), [@tallclair](https://github.com/tallclair)) [SIG Node].

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

? Please advise

/sig node
/priority important-soon
/milestone v1.32

k8s-ci-robot · 2024-10-23T12:31:16Z

@esotsal: You must be a member of the kubernetes/milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your Milestone Maintainers Team and have them propose you as an additional delegate for this responsibility.

In response to this:

What type of PR is this?

What this PR does / why we need it:

We want to introduce a new feature gate to allow resize for guaranteed pods on nodes with a static topology policy to unblock development on #127262.

New gate "AllowResourceResizeInContainerWithExclusiveCPUs" is off by default, but can be enabled to unblock development of Static CPU management alongside InPlacePodVerticalScaling.

Which issue(s) this PR fixes:

For #128068

Special notes for your reviewer:

Does this PR introduce a user-facing change?
- Ensure resizing for Guaranteed pods on nodes with static CPU & Memory policy configured is not allowed for the beta release of in-place resize. The feature gate `AllowResourceResizeInContainerWithExclusiveCPUs` defaults to `false`, but can be enabled to unblock development on ([#127262](https://github.com/kubernetes/kubernetes/issues/127262), [@tallclair](https://github.com/tallclair)) [SIG Node].
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
? Please advice
/sig node
/priority important-soon
/milestone v1.32

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

esotsal · 2024-10-23T12:31:56Z

/assign @tallclair

tallclair

Thanks for taking this on. I see this is tagged "WIP" so I assume it's still coming, but the feature gate should be implemented in this same PR (I mean rejecting the resize of exclusive CPU pods)

CHANGELOG/CHANGELOG-1.32.md

pkg/features/kube_features.go

pkg/features/versioned_kube_features.go

esotsal · 2024-10-23T18:48:30Z

Thanks for taking this on. I see this is tagged "WIP" so I assume it's still coming, but the feature gate should be implemented in this same PR (I mean rejecting the resize of exclusive CPU pods)

Correct , that’s the plan, plus necessary tests

…atic topology policy New gate "InPlacePodVerticalScalingExclusiveCPUs" is off by default, but can be enabled to unblock development of Static CPU management alongside InPlacePodVerticalScaling.

esotsal · 2024-11-07T17:20:03Z

/test pull-kubernetes-e2e-inplace-pod-resize-containerd-main-v2
/test pull-kubernetes-node-kubelet-serial-podresize
/test pull-kubernetes-node-kubelet-serial-crio-cgroupv2
/test pull-kubernetes-e2e-gce-cos-alpha-features

tallclair · 2024-11-07T22:33:13Z

/triage accepted
/milestone v1.32

tallclair · 2024-11-07T23:06:05Z

/lgtm
/approve

k8s-ci-robot · 2024-11-07T23:06:11Z

LGTM label has been added.

Git tree hash: 01b765e067dd4ef4b04c79e8a72433b7b23c62df

k8s-ci-robot · 2024-11-07T23:06:18Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: esotsal, tallclair

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~pkg/features/OWNERS~~ [tallclair]
~~pkg/kubelet/OWNERS~~ [tallclair]
~~test/featuregates_linter/test_data/OWNERS~~ [tallclair]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot · 2024-11-08T01:36:30Z

@esotsal: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-kubernetes-e2e-gce-cos-alpha-features	`2d8939c`	link	false	`/test pull-kubernetes-e2e-gce-cos-alpha-features`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

pacoxu · 2024-11-08T02:37:55Z

/kind feature
/skip

wendy-ha18 · 2024-11-08T02:57:01Z

Hi @pacoxu @tallclair
Appreciate all of your efforts with this PR!!
A gentle reminder that the code freeze has started 02:00 UTC Friday November 8th 2024 . Please make sure this has both lgtm and approved labels ASAP, and file an Exception.

sftim · 2024-11-11T18:14:39Z

Make sure to document InPlacePodVerticalScalingExclusiveCPUs for v1.32
(it's OK to file a k/website issue and delegate; in fact, I recommend it)

esotsal · 2024-11-11T18:22:13Z

Make sure to document InPlacePodVerticalScalingExclusiveCPUs for v1.32 (it's OK to file a k/website issue and delegate; in fact, I recommend it)

kubernetes/website#48687 created @sftim , thanks !

esotsal · 2025-07-28T14:29:40Z

Adding for tracking purposes, this PR is related with kubernetes/enhancements#5294

esotsal changed the title ~~[:InPlacePodVerticalScaling] WIP: Gate Disallow in-place resize for guaranteed pods on nodes with a static topology policy~~ [FG:InPlacePodVerticalScaling] WIP: Gate Disallow in-place resize for guaranteed pods on nodes with a static topology policy Oct 23, 2024

k8s-ci-robot requested review from kow3ns and liggitt October 23, 2024 12:31

k8s-ci-robot added area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. labels Oct 23, 2024

k8s-ci-robot assigned tallclair Oct 23, 2024

esotsal force-pushed the esotsal/128068 branch from 92b74cc to d7edb56 Compare October 23, 2024 13:34

tallclair reviewed Oct 23, 2024

View reviewed changes

CHANGELOG/CHANGELOG-1.32.md Outdated Show resolved Hide resolved

pkg/features/kube_features.go Outdated Show resolved Hide resolved

pkg/features/kube_features.go Outdated Show resolved Hide resolved

pkg/features/versioned_kube_features.go Outdated Show resolved Hide resolved

esotsal force-pushed the esotsal/128068 branch 7 times, most recently from 0957e98 to f4b1caa Compare October 26, 2024 22:33

k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/kubelet and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 26, 2024

esotsal force-pushed the esotsal/128068 branch from f4b1caa to 8a57cf6 Compare October 26, 2024 23:51

k8s-ci-robot removed the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 26, 2024

esotsal force-pushed the esotsal/128068 branch 2 times, most recently from 2d4a186 to 8b6da25 Compare November 7, 2024 16:52

Gate: disallow in-place resize for guaranteed pods on nodes with a st…

2d8939c

…atic topology policy New gate "InPlacePodVerticalScalingExclusiveCPUs" is off by default, but can be enabled to unblock development of Static CPU management alongside InPlacePodVerticalScaling.

esotsal force-pushed the esotsal/128068 branch from 8b6da25 to 2d8939c Compare November 7, 2024 17:18

k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 7, 2024

k8s-ci-robot added this to the v1.32 milestone Nov 7, 2024

k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Nov 7, 2024

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 7, 2024

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 7, 2024

k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Nov 8, 2024

k8s-ci-robot merged commit 81dc453 into kubernetes:master Nov 8, 2024
17 of 18 checks passed

esotsal deleted the esotsal/128068 branch November 8, 2024 05:44

esotsal mentioned this pull request Nov 11, 2024

Document InPlacePodVerticalScalingExclusiveCPUs for v1.32 kubernetes/website#48687

Closed

AnishShah mentioned this pull request Nov 13, 2024

umbrella issue for InPlacePodVerticalScaling documentation kubernetes/website#48534

Closed

tallclair mentioned this pull request Mar 21, 2025

In-Place Update of Pod Resources kubernetes/enhancements#1287

Open

95 tasks

pravk03 mentioned this pull request Jun 23, 2025

[FG:InPlacePodVerticalScaling] Create separate feature gates for static CPU Manager and static Memory Manager support #132466

Closed

[FG:InPlacePodVerticalScaling] Gate Disallow in-place resize for guaranteed pods on nodes with a static topology policy #128287

[FG:InPlacePodVerticalScaling] Gate Disallow in-place resize for guaranteed pods on nodes with a static topology policy #128287

Uh oh!

Conversation

esotsal commented Oct 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

Uh oh!

k8s-ci-robot commented Oct 23, 2024

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

Uh oh!

esotsal commented Oct 23, 2024

Uh oh!

tallclair left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

esotsal commented Oct 23, 2024

Uh oh!

esotsal commented Nov 7, 2024

Uh oh!

tallclair commented Nov 7, 2024

Uh oh!

tallclair commented Nov 7, 2024

Uh oh!

k8s-ci-robot commented Nov 7, 2024

Uh oh!

k8s-ci-robot commented Nov 7, 2024

Uh oh!

k8s-ci-robot commented Nov 8, 2024

Uh oh!

pacoxu commented Nov 8, 2024

Uh oh!

wendy-ha18 commented Nov 8, 2024

Uh oh!

Uh oh!

sftim commented Nov 11, 2024

Uh oh!

esotsal commented Nov 11, 2024

Uh oh!

esotsal commented Jul 28, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

esotsal commented Oct 23, 2024 •

edited

Loading

tallclair left a comment •

edited

Loading