Skip to content

[FG:InPlacePodVerticalScaling] Don't checkpoint ResizeStatus #128551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 6, 2024
Merged

[FG:InPlacePodVerticalScaling] Don't checkpoint ResizeStatus #128551

merged 2 commits into from
Nov 6, 2024

Conversation

@tallclair
Copy link
Member

@tallclair tallclair commented Nov 4, 2024 •
edited
Loading

What type of PR is this?

/kind feature

What this PR does / why we need it:

Resize status can be recomputed from known info and state, so there is no need to checkpoint it.

This PR consolidates the ResizeStatus calculations to handlePodResourcesResize, and removes it from the checkpoint.

Special notes for your reviewer:

Currently based on #128377. (merged)

Does this PR introduce a user-facing change?

NONE

/sig node
/priority important-soon

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. kind/feature Categorizes issue or PR as related to a new feature. sig/node Categorizes an issue or PR as relevant to SIG Node. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Nov 4, 2024
@tallclair
Copy link
Member Author

tallclair commented Nov 4, 2024

/triage accepted
/milestone v1.32

@k8s-ci-robot k8s-ci-robot added this to the v1.32 milestone Nov 4, 2024
@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework area/kubectl area/kubelet area/test kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Nov 4, 2024
yujuhong
yujuhong reviewed Nov 5, 2024
View reviewed changes
@tallclair tallclair force-pushed the allocated-checkpoint branch from d918711 to e4f1615 Compare November 5, 2024 23:42
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 5, 2024
@tallclair tallclair changed the title [WIP] [FG:InPlacePodVerticalScaling] Don't checkpoint ResizeStatus [FG:InPlacePodVerticalScaling] Don't checkpoint ResizeStatus Nov 5, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 5, 2024
@tallclair tallclair force-pushed the allocated-checkpoint branch from e4f1615 to ea53083 Compare November 5, 2024 23:48
@tallclair
Copy link
Member Author

tallclair commented Nov 5, 2024

Thanks @yujuhong. I cleaned up the comments, and rebased on #128377. This should be good-to-go now.

@tallclair
Copy link
Member Author

tallclair commented Nov 5, 2024

/assign @yujuhong

@yujuhong
Copy link
Contributor

yujuhong commented Nov 6, 2024

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 6, 2024
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 6, 2024

LGTM label has been added.

Git tree hash: d94908f80c3bfc73f355ae04d80de5cb52e1b10f

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tallclair, yujuhong

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-triage-robot
Copy link

k8s-triage-robot commented Nov 6, 2024

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@pacoxu
Copy link
Member

pacoxu commented Nov 6, 2024

/test pull-kubernetes-e2e-gce

@k8s-ci-robot k8s-ci-robot merged commit 5e0b818 into kubernetes:master Nov 6, 2024
14 checks passed
@tallclair tallclair mentioned this pull request Mar 21, 2025
Open
95 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andrewsykim andrewsykim Awaiting requested review from andrewsykim

@brianpursley brianpursley Awaiting requested review from brianpursley

1 more reviewer

@yujuhong yujuhong yujuhong left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@yujuhong yujuhong

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework area/kubectl area/kubelet area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Projects

SIG CLI
Archived in project
SIG Node CI/Test Board
Archived in project
SIG Node: In Place Pod Vertical Scaling
Status: Done
SIG Node: code and documentation PRs
Archived in project
[sig-release] Bug Triage
Archived in project

Milestone

v1.32

Development

Successfully merging this pull request may close these issues.

5 participants

@tallclair @yujuhong @k8s-ci-robot @k8s-triage-robot @pacoxu