[FG:InPlacePodVerticalScaling] Fix AllocatedResources feature gate annotation #128687
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/triage accepted |
|
/assign @thockin |
|
LGTM label has been added. Git tree hash: 3bcc7d1f64f9bdaeffa1a78424ce59cfadc7d627
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tallclair, thockin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
This PR may require API review. If so, when the changes are ready, complete the pre-review checklist and request an API review. Status of requested reviews is tracked in the API Review project. |
|
/test pull-kubernetes-node-e2e-containerd |
95 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
The feature gate guarding the
AllocatedResourcesfield changed in #128377, but I forgot to update the annotation on the field.Special notes for your reviewer:
Technically this field is guarded by both
InPlacePodVerticalScalingandInPlacePodVerticalScalingAllocatedStatus. Should I put both on the field? Like this:Does this PR introduce a user-facing change?
/sig node
/milestone v1.32
/priority important-soon