[FG:InPlacePodVerticalScaling] Remove ResizePolicy defaulting #128920
Conversation
|
This PR may require API review. If so, when the changes are ready, complete the pre-review checklist and request an API review. Status of requested reviews is tracked in the API Review project. |
| for _, p := range obj.Spec.Containers[i].ResizePolicy { | ||
| resizePolicySpecified[p.ResourceName] = true | ||
| } | ||
| setDefaultResizePolicy := func(resourceName v1.ResourceName) { |
There was a problem hiding this comment.
can drop the "defaulting" in the fuzzer as well now, right?
There was a problem hiding this comment.
Yeah, but that change was rolled back in #128875. We just won't add it back when we re-enable IPPVS.
|
LGTM label has been added. Git tree hash: eda658814510c575c4a229f1c6e0eb8ecad9eee3
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tallclair, thockin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
/kind api-change
What this PR does / why we need it:
Remove the explicit defaulting of the container ResizePolicy field, instead relying on implicit default behavior. See #128917
Which issue(s) this PR fixes:
Fixes #128917
Does this PR introduce a user-facing change?
/sig node
/priority important-soon
/milestone v1.33
/triage accepted