Skip to content

testing: Fix pod delete timeout failures after InPlacePodVerticalScaling Graduate to Beta commit #129717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 21, 2025
Merged

testing: Fix pod delete timeout failures after InPlacePodVerticalScaling Graduate to Beta commit #129717

merged 1 commit into from
Jan 21, 2025

Conversation

@esotsal
Copy link
Contributor

@esotsal esotsal commented Jan 20, 2025

What type of PR is this?

/kind bug
/kind failing-test

What this PR does / why we need it:

Please check analysis here and conversation in this PR below.

In brief this commit modifies testing code, and ensure same delete timeout duration is used, more specificaly

  • replaced DeletePod timeouts used before with framework.timeouts.PodDelete, previous timeouts where less than 5 minutes, please see full commit for details.

    kubernetes/test/e2e/framework/timeouts.go

    Line 26 in 35d098a

    PodDelete: 5 * time.Minute,

  • Replace of Delete with DeleteSync pod_resize test, with a 5 minute timeout, to ensure Pods are Deleted and will not impact some tests which were not resilient with the existence of pods.

Which issues this PR fixes

Relates to #128837
Fixes test failures due to pods not deleted with the introduction of InPlacePodVerticalScaling Beta

Special notes for your reviewer:

Please see files changes for more details.

This PR replace #128880 , needed due to company transfer.

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jan 20, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jan 20, 2025

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework area/test sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 20, 2025
@esotsal esotsal mentioned this pull request Jan 20, 2025
Closed
@esotsal
Copy link
Contributor Author

esotsal commented Jan 20, 2025 •
edited
Loading

@hshiina , @tallclair , @ffromani , @AnishShah , @pacoxu , @dims, @pohly , @aojea moved old PR here due to company transfer, now i can continue working on this, how do you think should we proceed with this?

@pacoxu
Copy link
Member

pacoxu commented Jan 21, 2025

/test pull-kubernetes-e2e-inplace-pod-resize-containerd-main-v2
/test pull-kubernetes-node-kubelet-serial-podresize
/test pull-kubernetes-node-kubelet-serial-crio-cgroupv2
/test pull-kubernetes-e2e-gce-cos-alpha-features
/test pull-kubernetes-node-kubelet-serial-containerd
/test pull-kubernetes-node-kubelet-serial-containerd-alpha-features
/test pull-kubernetes-node-kubelet-serial-containerd-sidecar-containers
/test pull-kubernetes-e2e-ec2
/test pull-kubernetes-e2e-gce-canary
/test pull-kubernetes-e2e-ec2-conformance
/test pull-kubernetes-e2e-capz-windows-master
/test pull-kubernetes-node-kubelet-serial-containerd-kubetest2

pacoxu
pacoxu approved these changes Jan 21, 2025
View reviewed changes
Copy link
Member

@pacoxu pacoxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/assign @tallclair @pohly @aojea

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 21, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jan 21, 2025

LGTM label has been added.

Git tree hash: e8c33d6905aaf6b30ccbbed37d738df6c36932f1

pohly
pohly approved these changes Jan 21, 2025
View reviewed changes
Copy link
Contributor

@pohly pohly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jan 21, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: esotsal, pacoxu, pohly

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 21, 2025
@esotsal esotsal mentioned this pull request Jan 21, 2025
Closed
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jan 21, 2025

@esotsal: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubernetes-node-kubelet-serial-containerd-alpha-features c5fc419 link false /test pull-kubernetes-node-kubelet-serial-containerd-alpha-features

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@k8s-triage-robot
Copy link

k8s-triage-robot commented Jan 21, 2025

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

  • The PR does have any do-not-merge/* labels
  • The PR does not have the needs-ok-to-test label
  • The PR is mergeable (does not have a needs-rebase label)
  • The PR is approved (has cncf-cla: yes, lgtm, approved labels)
  • The PR is failing tests required for merge

You can:

/retest

@k8s-ci-robot k8s-ci-robot merged commit a271299 into kubernetes:master Jan 21, 2025
22 of 23 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.33 milestone Jan 21, 2025
@esotsal esotsal deleted the fix-128837 branch January 22, 2025 00:52
@tallclair tallclair mentioned this pull request Mar 21, 2025
Open
95 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andrewsykim andrewsykim Awaiting requested review from andrewsykim

@brianpursley brianpursley Awaiting requested review from brianpursley

2 more reviewers

@pohly pohly pohly approved these changes

@pacoxu pacoxu pacoxu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@pohly pohly

@pacoxu pacoxu

@aojea aojea

@tallclair tallclair

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

SIG CLI
Archived in project
SIG Node CI/Test Board
Archived in project
SIG Node: In Place Pod Vertical Scaling
Status: Done

Milestone

v1.33

Development

Successfully merging this pull request may close these issues.

7 participants

@esotsal @k8s-ci-robot @pacoxu @k8s-triage-robot @pohly @aojea @tallclair