Skip to content

Fix pod resize E2E tests after forbidding memory limit decrease #130357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 24, 2025
Merged

Fix pod resize E2E tests after forbidding memory limit decrease #130357

merged 1 commit into from
Feb 24, 2025

Conversation

@tallclair
Copy link
Member

@tallclair tallclair commented Feb 21, 2025

What type of PR is this?

/kind failing-test

What this PR does / why we need it:

Follow up to #130183 to fix failing tests

Does this PR introduce a user-facing change?

NONE

/sig node
/priority important-soon

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. sig/node Categorizes an issue or PR as relevant to SIG Node. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Feb 21, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Feb 21, 2025

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Feb 21, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tallclair

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 21, 2025
@k8s-ci-robot k8s-ci-robot added area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Feb 21, 2025
@tallclair
Copy link
Member Author

tallclair commented Feb 21, 2025

/test pull-kubernetes-node-kubelet-serial-podresize
/test pull-kubernetes-e2e-inplace-pod-resize-containerd-main-v2

@tallclair tallclair mentioned this pull request Feb 21, 2025
Merged
@tallclair
Copy link
Member Author

tallclair commented Feb 21, 2025

/cc @pacoxu @aojea

@k8s-ci-robot k8s-ci-robot requested review from aojea and pacoxu February 21, 2025 23:50
@pacoxu
Copy link
Member

pacoxu commented Feb 24, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 24, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Feb 24, 2025

LGTM label has been added.

Git tree hash: 638e13421cbe35d07665d5bc02ea028fa3ae4c35

@k8s-ci-robot k8s-ci-robot merged commit b066ddc into kubernetes:master Feb 24, 2025
13 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.33 milestone Feb 24, 2025
@pacoxu pacoxu mentioned this pull request Feb 24, 2025
Closed
@esotsal esotsal mentioned this pull request Mar 2, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bobbypage bobbypage Awaiting requested review from bobbypage

@rphillips rphillips Awaiting requested review from rphillips

@aojea aojea Awaiting requested review from aojea

@pacoxu pacoxu Awaiting requested review from pacoxu

Assignees

@pacoxu pacoxu

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

SIG Node CI/Test Board
Archived in project

Milestone

v1.33

Development

Successfully merging this pull request may close these issues.

3 participants

@tallclair @k8s-ci-robot @pacoxu