Skip to content

[KEP-5100] WinDSR feature gate to GA #132108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 22, 2025
Merged

[KEP-5100] WinDSR feature gate to GA #132108

merged 2 commits into from
Jul 22, 2025
+5 −0

Conversation

@rzlink
Copy link
Contributor

@rzlink rzlink commented Jun 4, 2025

What type of PR is this?

/kind feature
/kind windows

What this PR does / why we need it:

GA graduation for the WinDSR feature.

Which issue(s) this PR fixes:

Fixes #kubernetes/enhancements#5100

Special notes for your reviewer:

Here are the graduation criteria: https://github.com/kubernetes/enhancements/tree/master/keps/sig-windows/5100-windows-dsr-and-overlay-support#graduation-criteria

Does this PR introduce a user-facing change?

Graduate the WinDSR feature in the kube-proxy to GA. The `WinDSR` feature gate is now enabled by default.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

[KEP]:  https://github.com/kubernetes/enhancements/tree/master/keps/sig-windows/5100-windows-dsr-and-overlay-support

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. kind/feature Categorizes issue or PR as related to a new feature. labels Jun 4, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jun 4, 2025

@rzlink: The label(s) kind/windows cannot be applied, because the repository doesn't have them.

In response to this:

What type of PR is this?

/kind feature
/kind windows

What this PR does / why we need it:

GA graduation for the WinDSR feature.

Which issue(s) this PR fixes:

Fixes #kubernetes/enhancements#5100

Special notes for your reviewer:

Here are the graduation criteria: https://github.com/kubernetes/enhancements/tree/master/keps/sig-windows/5100-windows-dsr-and-overlay-support#graduation-criteria

Does this PR introduce a user-facing change?

Graduate the WinDSR feature in the kube-proxy to GA. The `WinDSR` feature gate is now enabled by default.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

[KEP]:  https://github.com/kubernetes/enhancements/tree/master/keps/sig-windows/5100-windows-dsr-and-overlay-support

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 4, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jun 4, 2025

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jun 4, 2025

Hi @rzlink. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Jun 4, 2025
@k8s-ci-robot k8s-ci-robot requested review from dashpole and wojtek-t June 4, 2025 23:28
@rzlink
Copy link
Contributor Author

rzlink commented Jun 4, 2025

/assign @marosset

@marosset
Copy link
Contributor

marosset commented Jun 10, 2025

/sig windows network

@k8s-ci-robot k8s-ci-robot added sig/windows Categorizes an issue or PR as relevant to SIG Windows. sig/network Categorizes an issue or PR as relevant to SIG Network. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jun 10, 2025
@marosset
Copy link
Contributor

marosset commented Jun 10, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 10, 2025
@marosset marosset mentioned this pull request Jun 10, 2025
Open
9 tasks
@kannon92
Copy link
Contributor

kannon92 commented Jun 12, 2025

/hold

A KEP update/merge is required for this to go in for 1.34.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 12, 2025
@zylxjtu
Copy link
Contributor

zylxjtu commented Jun 18, 2025

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 18, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jun 18, 2025

LGTM label has been added.

Git tree hash: e8bf8c924aa324bd5d7e7bcb16d3853dbea36389

@zylxjtu
Copy link
Contributor

zylxjtu commented Jun 18, 2025

/approved

@jsturtevant
Copy link
Contributor

jsturtevant commented Jun 18, 2025

/assign @marosset @aravindhp

kannon92
kannon92 reviewed Jun 18, 2025
View reviewed changes
@rzlink rzlink requested a review from kannon92 June 18, 2025 20:56
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 18, 2025
kannon92
kannon92 reviewed Jun 18, 2025
View reviewed changes
@marosset
Copy link
Contributor

marosset commented Jul 17, 2025

/approve

We've had both a lot of test coverage (unit, e2e, and real-world usage) with DSR enabled on Windows for many releases

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jul 17, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: marosset, rzlink, zylxjtu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 17, 2025
@zylxjtu
Copy link
Contributor

zylxjtu commented Jul 17, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 17, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jul 17, 2025

LGTM label has been added.

Git tree hash: c10117f56885ae8749cf8b1107cdd2ad3a7fd573

@marosset
Copy link
Contributor

marosset commented Jul 22, 2025

/hold cancel
This is covered by kubernetes/enhancements#5100

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 22, 2025
@k8s-ci-robot k8s-ci-robot merged commit 52bc751 into kubernetes:master Jul 22, 2025
15 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.34 milestone Jul 22, 2025
@rzlink rzlink deleted the windsr branch July 23, 2025 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dashpole dashpole Awaiting requested review from dashpole

@wojtek-t wojtek-t Awaiting requested review from wojtek-t

@aravindhp aravindhp Awaiting requested review from aravindhp

@marosset marosset Awaiting requested review from marosset

@zylxjtu zylxjtu Awaiting requested review from zylxjtu

1 more reviewer

@kannon92 kannon92 kannon92 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@zylxjtu zylxjtu

@aravindhp aravindhp

@marosset marosset

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/windows Categorizes an issue or PR as relevant to SIG Windows. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

v1.34

Development

Successfully merging this pull request may close these issues.

7 participants

@rzlink @k8s-ci-robot @marosset @kannon92 @zylxjtu @jsturtevant @aravindhp