Skip to content

Conversation

@timstclair
Copy link

For kubernetes/enhancements#24

/cc @kubernetes/sig-node @erictune @matchstick

@timstclair timstclair added area/security kind/documentation Categorizes issue or PR as related to documentation. labels Jul 19, 2016
@timstclair timstclair added this to the v1.4 milestone Jul 19, 2016
@k8s-github-robot k8s-github-robot added kind/design Categorizes issue or PR as related to design. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. release-note-label-needed labels Jul 19, 2016
@timstclair timstclair added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note-label-needed kind/documentation Categorizes issue or PR as related to documentation. labels Jul 19, 2016
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a good route, because doing the "install" of the profile is an ugly exec of apparmor_parser ;) best just to leave it to the admin so yay

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack. I'm guessing that building a solution for deploying profiles will be high priority though, even if it doesn't make the alpha feature list...

@Amey-D
Copy link
Contributor

Amey-D commented Jul 19, 2016

/cc @kubernetes/goog-image FYI

@Amey-D
Copy link
Contributor

Amey-D commented Jul 19, 2016

Do you have any guidelines for users on how to provision K8s nodes with AppArmor profiles(e.g., how to bring the profiles on to the nodes, and how to apply them before Kubelet can start their containers)?

@timstclair
Copy link
Author

Do you have any guidelines for users on how to provision K8s nodes with AppArmor profiles(e.g., how to bring the profiles on to the nodes, and how to apply them before Kubelet can start their containers)?

I was considering this problem to be out of the scope for alpha, but can reconsider if you think otherwise. Users may end up building the solution proposed in deploying profiles anyway, so it might be best to offer it as an "unofficial" (a.k.a. pre-alpha) option.

@timstclair
Copy link
Author

After several conversations in other channels, I decided that it would be helpful to provide a reference implementation for loading profiles onto nodes. I've added a section describing the approach, as well as a testing plan.

PTAL

@jessfraz
Copy link
Contributor

LGTM, the new stuff with getting profiles on the nodes as well :)

@timstclair
Copy link
Author

Thanks! Adding LGTM label.

@timstclair timstclair added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Jul 25, 2016
@timstclair
Copy link
Author

Squashed & rebased.

@timstclair timstclair added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 25, 2016
@timstclair
Copy link
Author

Reran hack/update-munge-docs.sh. Reapplying LGTM.

@timstclair timstclair added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Jul 25, 2016
@timstclair
Copy link
Author

Apparantly the munger was using my alternate gopath as ustream. Fixed & reran.

@timstclair timstclair added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Jul 25, 2016
@k8s-bot
Copy link

k8s-bot commented Jul 25, 2016

GCE e2e build/test passed for commit 55c39b9.

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit eb60b06 into kubernetes:master Jul 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/security kind/design Categorizes issue or PR as related to design. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants