Update cadvisor and other repos for klog #70889
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/priority important-soon |
|
/test pull-kubernetes-e2e-gke |
|
/assign @mikedanese @thockin |
77df3a7 to
513f595
Compare
|
Racking up the big numbers! /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dims, thockin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Review the full test history for this PR. Silence the bot with an |
1 similar comment
|
/retest Review the full test history for this PR. Silence the bot with an |
- Move from the old github.com/golang/glog to k8s.io/klog - klog as explicit InitFlags() so we add them as necessary - we update the other repositories that we vendor that made a similar change from glog to klog * github.com/kubernetes/repo-infra * k8s.io/gengo/ * k8s.io/kube-openapi/ * github.com/google/cadvisor - Entirely remove all references to glog - Fix some tests by explicit InitFlags in their init() methods Change-Id: I92db545ff36fcec83afe98f550c9e630098b3135
Change-Id: I3b1ca9f2687388c831d9d46a4e1de413ffae06ac
Change-Id: I31aa2483065a4ef6acb65c18cda73c325c432df3
Change-Id: I64b30c68a606b4f5c095a66496a1e48c4d62ea88
|
/retest Review the full test history for this PR. Silence the bot with an |
Change-Id: I27ff0545bc456ed8c0900cfeb90555f9ab7ae235
513f595 to
e558e29
Compare
|
New changes are detected. LGTM label has been removed. |
|
reapply |
|
/test pull-kubernetes-e2e-gke |
k8s-ci-robot
pushed a commit
that referenced
this pull request
Nov 23, 2018
The inotify code was removed from golang.org/x/exp several years ago. Therefore importing it from that path prevents downstream consumers from using any module that makes use of more recent features of golang.org/x/exp. This change is a followup to google/cadvisor#2060 which was merged with #70889 This fixes #68478
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
change from glog to klog
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #70264
Special notes for your reviewer:
Does this PR introduce a user-facing change?: