Skip to content

Include port names in the 'minikube service' cmd's output#5290

Merged
tstromberg merged 1 commit intokubernetes:masterfrom
11janci:jjanik-service-output
Sep 17, 2019
Merged

Include port names in the 'minikube service' cmd's output#5290
tstromberg merged 1 commit intokubernetes:masterfrom
11janci:jjanik-service-output

Conversation

@11janci
Copy link
Copy Markdown
Contributor

@11janci 11janci commented Sep 7, 2019 •
edited
Loading

Extend the minikube service {service_name} command's output by adding a new column 'Target Port' for port names.

Pls note that currently the column is included always and will be empty if there are no node ports or target ports. Let me know if you'd like to hide it if empty, add a flag for showing it (as suggested in the linked issue), or rename the column's header.

Before

|-----------|---------------------|--------------|
| NAMESPACE |        NAME         |      URL     |
|-----------|---------------------|--------------|
| default   | kubernetes-bootcamp | No node port |
|-----------|---------------------|--------------|

After

|-----------|---------------------|-------------|--------------|
| NAMESPACE |        NAME         | TARGET PORT |     URL      |
|-----------|---------------------|-------------|--------------|
| default   | kubernetes-bootcamp |             | No node port |
|-----------|---------------------|-------------|--------------|

|-----------|-------------------|-------------|--------------------------------|
| NAMESPACE |       NAME        | TARGET PORT |              URL               |
|-----------|-------------------|-------------|--------------------------------|
| default   | nothing-minecraft | server      | http://192.168.99.100:32225    |
|           |                   | dynmap      | http://192.168.99.100:32412    |
|-----------|-------------------|-------------|--------------------------------|

Closes #5200

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 7, 2019
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Sep 7, 2019

Hi @11janci. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 7, 2019
@minikube-bot
Copy link
Copy Markdown
Collaborator

minikube-bot commented Sep 7, 2019

Can one of the admins verify this patch?

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 7, 2019
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Sep 7, 2019

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 11janci
To complete the pull request process, please assign ra489
You can assign the PR to them by writing /assign @ra489 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@11janci
Copy link
Copy Markdown
Contributor Author

11janci commented Sep 7, 2019

/assign @RA489

@11janci 11janci force-pushed the jjanik-service-output branch from ba7d3bb to 9d16f7e Compare September 7, 2019 11:17
@tstromberg
Copy link
Copy Markdown
Contributor

tstromberg commented Sep 9, 2019

For clarification when reviewing UI changes, it's useful to have a "before" and "after" example. Do you mind adding a "before" example to your PR description?

@11janci
Copy link
Copy Markdown
Contributor Author

11janci commented Sep 9, 2019

For clarification when reviewing UI changes, it's useful to have a "before" and "after" example. Do you mind adding a "before" example to your PR description?

done

@tstromberg tstromberg merged commit b73ec8c into kubernetes:master Sep 17, 2019
@11janci 11janci deleted the jjanik-service-output branch July 14, 2020 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@medyagh medyagh Awaiting requested review from medyagh

1 more reviewer

@tstromberg tstromberg tstromberg approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@RA489 RA489

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

minikube service could handle multiple-ports-per-service better

5 participants

@11janci @k8s-ci-robot @minikube-bot @tstromberg @RA489