Skip to content

Initial translations for fr, es, de, ja, and zh-CN#5466

Merged
tstromberg merged 1 commit intokubernetes:masterfrom
sharifelgamal:initial-translations
Sep 26, 2019
Merged

Initial translations for fr, es, de, ja, and zh-CN#5466
tstromberg merged 1 commit intokubernetes:masterfrom
sharifelgamal:initial-translations

Conversation

@sharifelgamal
Copy link
Copy Markdown
Contributor

This PR adds translated output for most of minikube start and minikube delete, including help text, for French (fr), German (de), Japanese (ja), Spanish (es) and Simplified Chinese (zh-CN).

Help wanted for adding more languages, and filling out more phrases for existing languages! Documentation on how will be added shortly.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 26, 2019
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Sep 26, 2019
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sharifelgamal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 26, 2019
@TravisBuddy
Copy link
Copy Markdown

Hey @sharifelgamal,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 64546da0-dfff-11e9-a161-570cf9dcad8d

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #5466 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5466      +/-   ##
==========================================
+ Coverage   36.58%   36.59%   +<.01%     
==========================================
  Files         102      102              
  Lines        7311     7312       +1     
==========================================
+ Hits         2675     2676       +1     
  Misses       4285     4285              
  Partials      351      351
Impacted Files Coverage Δ
pkg/minikube/extract/extract.go 50.83% <100%> (+0.2%) ⬆️

@tstromberg tstromberg merged commit fedb06a into kubernetes:master Sep 26, 2019
@sharifelgamal sharifelgamal deleted the initial-translations branch October 11, 2019 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants