Skip to content

start: Remove create/delete retry loop#6129

Merged
tstromberg merged 1 commit intokubernetes:masterfrom
tstromberg:no-create-retry
Dec 20, 2019
Merged

start: Remove create/delete retry loop#6129
tstromberg merged 1 commit intokubernetes:masterfrom
tstromberg:no-create-retry

Conversation

@tstromberg
Copy link
Copy Markdown
Contributor

@tstromberg tstromberg commented Dec 20, 2019 •
edited
Loading

It caused more problems than it solved. It rarely helped, and users did not like that it automatically deleted the VM over transient issues.

Fixes #5941

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 20, 2019
@tstromberg
Copy link
Copy Markdown
Contributor Author

tstromberg commented Dec 20, 2019

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 20, 2019
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Dec 20, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tstromberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 20, 2019
@tstromberg tstromberg changed the title Disable StartHost retry. It caused more problems than it solved Disable StartHost retry Dec 20, 2019
@tstromberg tstromberg requested a review from medyagh December 20, 2019 00:13
@tstromberg tstromberg changed the title Disable StartHost retry Only try to start the host once: don't delete it and try again Dec 20, 2019
@tstromberg tstromberg changed the title Only try to start the host once: don't delete it and try again start: Remove create/delete retry loop Dec 20, 2019
@tstromberg tstromberg merged commit d24c802 into kubernetes:master Dec 20, 2019
@codecov-io
Copy link
Copy Markdown

codecov-io commented Dec 20, 2019

Codecov Report

Merging #6129 into master will increase coverage by 0.03%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6129      +/-   ##
==========================================
+ Coverage   36.73%   36.76%   +0.03%     
==========================================
  Files         113      113              
  Lines        8361     8354       -7     
==========================================
  Hits         3071     3071              
+ Misses       4887     4880       -7     
  Partials      403      403
Impacted Files Coverage Δ
cmd/minikube/cmd/start.go 22.93% <0%> (+0.23%) ⬆️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@medyagh medyagh medyagh approved these changes

@RA489 RA489 Awaiting requested review from RA489

@sharifelgamal sharifelgamal Awaiting requested review from sharifelgamal

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

hyperv: bad retry behavior: config.json: The system cannot find the file specified

4 participants

@tstromberg @k8s-ci-robot @codecov-io @medyagh