only copy apiserver certs to control plane #8092

sharifelgamal · 2020-05-12T18:55:03Z

No description provided.

k8s-ci-robot · 2020-05-12T18:55:17Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sharifelgamal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [sharifelgamal]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

medyagh · 2020-05-12T19:23:51Z

/ok-to-test

minikube-pr-bot · 2020-05-12T19:26:07Z

kvm2 Driver
docker Driver

pkg/minikube/bootstrapper/certs.go

…r-crt

minikube-pr-bot · 2020-05-13T16:52:36Z

kvm2 Driver
Times for minikube: [66.79303856700001 66.14715133099999 71.25599680500001]
Average time for minikube: 68.06539556766666

Times for Minikube (PR 8092): [68.49719856799999 67.154387946 68.68421028600001]
Average time for Minikube (PR 8092): 68.11193226666667

Averages Time Per Log

Details

+--------------------------------+-----------+--------------------+
|              LOG               | MINIKUBE  | MINIKUBE (PR 8092) |
+--------------------------------+-----------+--------------------+
| * minikube v1.10.1 on Debian   |  0.061004 |           0.063193 |
|                           9.11 |           |                    |
| * Using the kvm2 driver based  |  0.020369 |           0.021141 |
| on existing profile            |           |                    |
| * Starting control plane node  |  0.005738 |           0.003990 |
| minikube in cluster minikube   |           |                    |
| * Creating kvm2 VM (CPUs=2,    | 41.227761 |          42.121656 |
| Memory=3700MB, Disk=20000MB)   |           |                    |
| ...                            |           |                    |
| * Preparing Kubernetes v1.18.2 | 24.365536 |          23.658565 |
| on Docker 19.03.8 ...          |           |                    |
| * Verifying Kubernetes         |  1.558329 |           1.576168 |
| components...                  |           |                    |
| * Enabled addons:              |  0.751424 |           0.570348 |
| default-storageclass,          |           |                    |
| storage-provisioner            |           |                    |
| * Done! kubectl is now         |  0.071583 |           0.091891 |
| configured to use "minikube"   |           |                    |
|                                |  0.003651 |           0.004980 |
+--------------------------------+-----------+--------------------+

docker Driver
Times for minikube: [27.696875245999998 29.067062430999997 27.347202120999995]
Average time for minikube: 28.037046599333326

Times for Minikube (PR 8092): [29.110598851 28.393647830000003 28.625254584999997]
Average time for Minikube (PR 8092): 28.709833755333335

Averages Time Per Log

Details

+----------------------------------------+-----------+--------------------+
|                  LOG                   | MINIKUBE  | MINIKUBE (PR 8092) |
+----------------------------------------+-----------+--------------------+
| * minikube v1.10.1 on Debian           |  0.072562 |           0.071897 |
|                                   9.11 |           |                    |
| * Using the docker driver              |  0.002804 |           0.003152 |
| based on existing profile              |           |                    |
| * Starting control plane node          |  0.061364 |           0.065812 |
| minikube in cluster minikube           |           |                    |
| * Creating docker container            |  8.449026 |           8.470444 |
| (CPUs=2, Memory=3700MB) ...            |           |                    |
| * Preparing Kubernetes v1.18.2         |  0.125928 |           0.131489 |
| on Docker 19.03.2 ...                  |           |                    |
|   -                                    | 18.370212 |          18.470110 |
| kubeadm.pod-network-cidr=10.244.0.0/16 |           |                    |
| * Verifying Kubernetes                 |  0.873583 |           1.324273 |
| components...                          |           |                    |
| * Enabled addons:                      |  0.003270 |           0.088504 |
| default-storageclass,                  |           |                    |
| storage-provisioner                    |           |                    |
| * Done! kubectl is now                 |  0.073261 |           0.079306 |
| configured to use "minikube"           |           |                    |
|                                        |  0.005035 |           0.004847 |
+----------------------------------------+-----------+--------------------+

…r-crt

minikube-pr-bot · 2020-05-13T23:58:06Z

kvm2 Driver
Times for minikube: [64.443231327 61.249991550000004 65.487353223]
Average time for minikube: 63.72685870000001

Times for Minikube (PR 8092): [67.00379468799999 66.30724640599999 62.12066700199999]
Average time for Minikube (PR 8092): 65.14390269866668

Averages Time Per Log

Details

+--------------------------------+-----------+--------------------+
|              LOG               | MINIKUBE  | MINIKUBE (PR 8092) |
+--------------------------------+-----------+--------------------+
| * minikube v1.10.1 on Debian   |  0.059023 |           0.055107 |
|                           9.11 |           |                    |
| * Using the kvm2 driver based  |  0.019209 |           0.018097 |
| on existing profile            |           |                    |
| * Starting control plane node  |  0.004175 |           0.003194 |
| minikube in cluster minikube   |           |                    |
| * Creating kvm2 VM (CPUs=2,    | 40.329521 |          40.845338 |
| Memory=3700MB, Disk=20000MB)   |           |                    |
| ...                            |           |                    |
| * Preparing Kubernetes v1.18.2 | 21.258876 |          21.991832 |
| on Docker 19.03.8 ...          |           |                    |
| * Verifying Kubernetes         |  1.344061 |           1.407949 |
| components...                  |           |                    |
| * Enabled addons:              |  0.627871 |           0.739240 |
| default-storageclass,          |           |                    |
| storage-provisioner            |           |                    |
| * Done! kubectl is now         |  0.080702 |           0.078109 |
| configured to use "minikube"   |           |                    |
|                                |  0.003422 |           0.005037 |
+--------------------------------+-----------+--------------------+

docker Driver
Times for minikube: [28.310330405999995 26.858402438000002 28.458561473000007]
Average time for minikube: 27.87576477233333

Times for Minikube (PR 8092): [51.217150996 26.964743197 25.596013924]
Average time for Minikube (PR 8092): 34.592636039000006

Averages Time Per Log

Details

+----------------------------------------+-----------+--------------------+
|                  LOG                   | MINIKUBE  | MINIKUBE (PR 8092) |
+----------------------------------------+-----------+--------------------+
| * minikube v1.10.1 on Debian           |  0.065226 |           0.067155 |
|                                   9.11 |           |                    |
| * Using the docker driver              |  0.002312 |           0.002532 |
| based on existing profile              |           |                    |
| * Starting control plane node          |  0.056971 |           0.059422 |
| minikube in cluster minikube           |           |                    |
| * Creating docker container            |  7.475811 |           7.586907 |
| (CPUs=2, Memory=3700MB) ...            |           |                    |
| * Preparing Kubernetes v1.18.2         |  0.118808 |           0.146148 |
| on Docker 19.03.2 ...                  |           |                    |
|   -                                    | 18.422083 |          25.799287 |
| kubeadm.pod-network-cidr=10.244.0.0/16 |           |                    |
| * Verifying Kubernetes                 |  1.598966 |           0.751918 |
| components...                          |           |                    |
| * Enabled addons:                      |  0.066613 |           0.107696 |
| default-storageclass,                  |           |                    |
| storage-provisioner                    |           |                    |
| * Done! kubectl is now                 |  0.064170 |           0.066685 |
| configured to use "minikube"           |           |                    |
|                                        |  0.004805 |           0.004887 |
+----------------------------------------+-----------+--------------------+

codecov-io · 2020-05-13T23:59:56Z

Codecov Report

Merging #8092 into master will decrease coverage by 0.75%.
The diff coverage is 20.00%.

@@            Coverage Diff             @@
##           master    #8092      +/-   ##
==========================================
- Coverage   35.27%   34.51%   -0.76%     
==========================================
  Files         146      146              
  Lines        9326     9328       +2     
==========================================
- Hits         3290     3220      -70     
- Misses       5637     5714      +77     
+ Partials      399      394       -5

Impacted Files	Coverage Δ
pkg/minikube/bootstrapper/certs.go	`43.08% <20.00%> (-28.24%)`	⬇️

medyagh · 2020-05-14T04:36:02Z

/retest-this-please

minikube-pr-bot · 2020-05-14T21:25:36Z

kvm2 Driver
Times for minikube: [74.348935051 70.15963979 72.56731356399999]
Average time for minikube: 72.35862946833333

Times for Minikube (PR 8092): [68.70981467700001 66.03770801200001 66.209481777]
Average time for Minikube (PR 8092): 66.98566815533334

Averages Time Per Log

Details

+--------------------------------+-----------+--------------------+
|              LOG               | MINIKUBE  | MINIKUBE (PR 8092) |
+--------------------------------+-----------+--------------------+
| * minikube v1.10.1 on Debian   |  0.068619 |           0.072956 |
|                           9.11 |           |                    |
| * Using the kvm2 driver based  |  0.025120 |           0.023081 |
| on existing profile            |           |                    |
| * Starting control plane node  |  0.004271 |           0.004040 |
| minikube in cluster minikube   |           |                    |
| * Creating kvm2 VM (CPUs=2,    | 44.089113 |          40.403718 |
| Memory=3700MB, Disk=20000MB)   |           |                    |
| ...                            |           |                    |
| * Preparing Kubernetes v1.18.2 | 25.768788 |          24.386278 |
| on Docker 19.03.8 ...          |           |                    |
| * Verifying Kubernetes         |  1.605839 |           1.499881 |
| components...                  |           |                    |
| * Enabled addons:              |  0.689125 |           0.508007 |
| default-storageclass,          |           |                    |
| storage-provisioner            |           |                    |
| * Done! kubectl is now         |  0.103416 |           0.081565 |
| configured to use "minikube"   |           |                    |
|                                |  0.004339 |           0.006142 |
+--------------------------------+-----------+--------------------+

docker Driver
Times for minikube: [29.735732847999998 33.26682891600001 28.516194111]
Average time for minikube: 30.506251958333337

Times for Minikube (PR 8092): [29.159778503000002 28.232005013000002 28.798183447999996]
Average time for Minikube (PR 8092): 28.729988988000002

Averages Time Per Log

Details

+----------------------------------------+-----------+--------------------+
|                  LOG                   | MINIKUBE  | MINIKUBE (PR 8092) |
+----------------------------------------+-----------+--------------------+
| * minikube v1.10.1 on Debian           |  0.081097 |           0.085135 |
|                                   9.11 |           |                    |
| * Using the docker driver              |  0.004007 |           0.003781 |
| based on existing profile              |           |                    |
| * Starting control plane node          |  0.065236 |           0.068941 |
| minikube in cluster minikube           |           |                    |
| * Creating docker container            |  8.592534 |           8.555891 |
| (CPUs=2, Memory=3700MB) ...            |           |                    |
| * Preparing Kubernetes v1.18.2         |  0.154884 |           0.134110 |
| on Docker 19.03.2 ...                  |           |                    |
|   -                                    | 19.888814 |          18.769964 |
| kubeadm.pod-network-cidr=10.244.0.0/16 |           |                    |
| * Verifying Kubernetes                 |  1.602196 |           0.950522 |
| components...                          |           |                    |
| * Enabled addons:                      |  0.024908 |           0.078718 |
| default-storageclass,                  |           |                    |
| storage-provisioner                    |           |                    |
| * Done! kubectl is now                 |  0.088951 |           0.075048 |
| configured to use "minikube"           |           |                    |
|                                        |  0.003625 |           0.007879 |
+----------------------------------------+-----------+--------------------+

sharifelgamal · 2020-05-15T16:13:30Z

/retest-this-please

…r-crt

minikube-pr-bot · 2020-05-15T22:18:43Z

kvm2 Driver
Times for minikube: [65.865391625 70.173130351 68.23900190900001]
Average time for minikube: 68.09250796166667

Times for Minikube (PR 8092): [68.13543527299998 63.85251315600001 65.42705940100001]
Average time for Minikube (PR 8092): 65.80500261000002

Averages Time Per Log

Details

+--------------------------------+-----------+--------------------+
|              LOG               | MINIKUBE  | MINIKUBE (PR 8092) |
+--------------------------------+-----------+--------------------+
| * minikube v1.10.1 on Debian   |  0.066280 |           0.066661 |
|                           9.11 |           |                    |
| * Using the kvm2 driver based  |  0.022765 |           0.022164 |
| on existing profile            |           |                    |
| * Starting control plane node  |  0.003876 |           0.003644 |
| minikube in cluster minikube   |           |                    |
| * Creating kvm2 VM (CPUs=2,    | 41.376968 |          41.394330 |
| Memory=3700MB, Disk=20000MB)   |           |                    |
| ...                            |           |                    |
| * Preparing Kubernetes v1.18.2 | 24.362430 |          22.299976 |
| on Docker 19.03.8 ...          |           |                    |
| * Verifying Kubernetes         |  1.703700 |           1.457525 |
| components...                  |           |                    |
| * Enabled addons:              |  0.459931 |           0.488266 |
| default-storageclass,          |           |                    |
| storage-provisioner            |           |                    |
| * Done! kubectl is now         |  0.092276 |           0.068569 |
| configured to use "minikube"   |           |                    |
|                                |  0.004282 |           0.003867 |
+--------------------------------+-----------+--------------------+

docker Driver
Times for minikube: [28.983924365999997 29.331820215999997 27.735816715]
Average time for minikube: 28.68385376566667

Times for Minikube (PR 8092): [28.036949643999996 27.76895535 28.449393822]
Average time for Minikube (PR 8092): 28.08509960533333

Averages Time Per Log

Details

+----------------------------------------+-----------+--------------------+
|                  LOG                   | MINIKUBE  | MINIKUBE (PR 8092) |
+----------------------------------------+-----------+--------------------+
| * minikube v1.10.1 on Debian           |  0.083961 |           0.081698 |
|                                   9.11 |           |                    |
| * Using the docker driver              |  0.003517 |           0.002821 |
| based on existing profile              |           |                    |
| * Starting control plane node          |  0.066559 |           0.065434 |
| minikube in cluster minikube           |           |                    |
| * Creating docker container            |  8.366846 |           8.061915 |
| (CPUs=2, Memory=3700MB) ...            |           |                    |
| * Preparing Kubernetes v1.18.2         |  0.130868 |           0.152271 |
| on Docker 19.03.2 ...                  |           |                    |
|   -                                    | 18.716041 |          18.583086 |
| kubeadm.pod-network-cidr=10.244.0.0/16 |           |                    |
| * Verifying Kubernetes                 |  1.216114 |           1.021473 |
| components...                          |           |                    |
| * Enabled addons:                      |  0.027740 |           0.035653 |
| default-storageclass,                  |           |                    |
| storage-provisioner                    |           |                    |
| * Done! kubectl is now                 |  0.067888 |           0.076985 |
| configured to use "minikube"           |           |                    |
|                                        |  0.004320 |           0.003764 |
+----------------------------------------+-----------+--------------------+

sharifelgamal · 2020-05-18T16:31:42Z

The test failures are all accounted for in existing issues. KVM is old k8s version, vbox linux is TestErrorSpam.

codecov-commenter · 2025-08-03T22:28:13Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 34.54%. Comparing base (bf1284b) to head (5b53495).
⚠️ Report is 15736 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #8092      +/-   ##
==========================================
- Coverage   35.27%   34.54%   -0.73%     
==========================================
  Files         146      146              
  Lines        9327     9329       +2     
==========================================
- Hits         3290     3223      -67     
- Misses       5638     5712      +74     
+ Partials      399      394       -5

Files with missing lines	Coverage Δ
pkg/minikube/bootstrapper/certs.go	`44.26% <100.00%> (-27.05%)`	⬇️

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

only copy apiserver certs to control plane

09698e4

sharifelgamal requested a review from medyagh May 12, 2020 18:55

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 12, 2020

k8s-ci-robot requested review from RA489 and blueelvis May 12, 2020 18:55

k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 12, 2020

k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label May 12, 2020

medyagh reviewed May 12, 2020

View reviewed changes

pkg/minikube/bootstrapper/certs.go Outdated Show resolved Hide resolved

Merge branch 'master' of github.com:kubernetes/minikube into apiserve…

70bec7a

…r-crt

Merge branch 'master' of github.com:kubernetes/minikube into apiserve…

148f052

…r-crt

move condition around for clarity

475bcc8

Merge branch 'master' of github.com:kubernetes/minikube into apiserve…

5b53495

…r-crt

sharifelgamal merged commit 9a03195 into kubernetes:master May 18, 2020

fmotrifork mentioned this pull request Jun 2, 2020

minikube 1.11.0 fishworks/fish-food#764

Merged

only copy apiserver certs to control plane #8092

only copy apiserver certs to control plane #8092

Uh oh!

Conversation

sharifelgamal commented May 12, 2020

Uh oh!

k8s-ci-robot commented May 12, 2020

Uh oh!

medyagh commented May 12, 2020

Uh oh!

minikube-pr-bot commented May 12, 2020

Uh oh!

Uh oh!

minikube-pr-bot commented May 13, 2020

Uh oh!

minikube-pr-bot commented May 13, 2020

Uh oh!

codecov-io commented May 13, 2020

Codecov Report

Uh oh!

medyagh commented May 14, 2020

Uh oh!

minikube-pr-bot commented May 14, 2020

Uh oh!

sharifelgamal commented May 15, 2020

Uh oh!

minikube-pr-bot commented May 15, 2020

Uh oh!

sharifelgamal commented May 18, 2020

Uh oh!

codecov-commenter commented Aug 3, 2025

Codecov Report

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants