Skip to content

Log stacks for slowjam analysis if STACKLOG_PATH is set#8329

Merged
medyagh merged 1 commit into
kubernetes:masterfrom
tstromberg:stacklog
Jun 4, 2020
Merged

Log stacks for slowjam analysis if STACKLOG_PATH is set#8329
medyagh merged 1 commit into
kubernetes:masterfrom
tstromberg:stacklog

Conversation

@tstromberg

@tstromberg tstromberg commented May 30, 2020

Copy link
Copy Markdown
Contributor

This enables performance analysis with the newly open-sourced https://github.com/tstromberg/minikube/pull/new/stacklog

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 30, 2020
@k8s-ci-robot

k8s-ci-robot commented May 30, 2020

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tstromberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from RA489 and priyawadhwa May 30, 2020 03:53
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 30, 2020
@codecov-commenter

codecov-commenter commented May 30, 2020

Copy link
Copy Markdown

Codecov Report

Merging #8329 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #8329   +/-   ##
=======================================
  Coverage   34.19%   34.19%           
=======================================
  Files         150      150           
  Lines        9574     9574           
=======================================
  Hits         3274     3274           
  Misses       5899     5899           
  Partials      401      401

priyawadhwa
priyawadhwa approved these changes Jun 1, 2020
View reviewed changes

@priyawadhwa priyawadhwa left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!!

@sharifelgamal

sharifelgamal commented Jun 3, 2020

Copy link
Copy Markdown
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jun 3, 2020
@minikube-pr-bot

minikube-pr-bot commented Jun 3, 2020

Copy link
Copy Markdown

kvm2 Driver
docker Driver

@medyagh medyagh merged commit 025ba11 into kubernetes:master Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RA489 RA489 Awaiting requested review from RA489

1 more reviewer

@priyawadhwa priyawadhwa priyawadhwa approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@tstromberg @k8s-ci-robot @codecov-commenter @sharifelgamal @minikube-pr-bot @priyawadhwa @medyagh