Skip to content

bridge cni: Make sure to create the directory for cni config #10868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
medyagh merged 1 commit into from
Mar 23, 2021
Merged

bridge cni: Make sure to create the directory for cni config #10868

medyagh merged 1 commit into from
Mar 23, 2021

Conversation

@afbjorklund
Copy link
Collaborator

@afbjorklund afbjorklund commented Mar 18, 2021

Otherwise it will be created with the mktemp permissions
and become unreadable (0700), making chmod fail later on.

Fixes error seen in #10852 (comment)

💣 Error starting cluster: apply cni: cni apply: copy: chmod /etc/cni/net.d/1-k8s.conf: permission denied

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 18, 2021
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 18, 2021
ilya-zuyev
ilya-zuyev reviewed Mar 18, 2021
View reviewed changes
@afbjorklund
Make sure to create the directory for cni config
c462f6c 
Otherwise it will be created with the mktemp permissions
and become unreadable (0700), making chmod fail later on.
@afbjorklund afbjorklund requested a review from ilya-zuyev March 19, 2021 16:11
@medyagh medyagh changed the title Make sure to create the directory for cni config bridge cni: Make sure to create the directory for cni config Mar 23, 2021
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Mar 23, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afbjorklund, medyagh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [afbjorklund,medyagh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@medyagh
Copy link
Member

medyagh commented Mar 23, 2021

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Mar 23, 2021
@kubernetes kubernetes deleted a comment from minikube-pr-bot Mar 23, 2021
@medyagh
Copy link
Member

medyagh commented Mar 23, 2021

/retest-this-please

@medyagh
Copy link
Member

medyagh commented Mar 23, 2021

Weirdly both docker Linux and kvm tests timed out...I am gonna retest to see what is going on.

@minikube-pr-bot
Copy link

minikube-pr-bot commented Mar 23, 2021

kvm2 Driver
Times for minikube: 66.1s 68.0s 65.7s
Average time for minikube: 66.6s

Times for Minikube (PR 10868): 65.1s 64.9s 67.0s
Average time for Minikube (PR 10868): 65.7s

Averages Time Per Log

Details 
+--------------------------------------------+----------+---------------------+
|                    LOG                     | MINIKUBE | MINIKUBE (PR 10868) |
+--------------------------------------------+----------+---------------------+
| * minikube v1.18.1 on Debian               | 0.1s     | 0.0s                |
| 9.11 (kvm/amd64)                           |          |                     |
| * Using the kvm2 driver based              | 0.0s     | 0.0s                |
| on user configuration                      |          |                     |
| * Starting control plane node              | 0.0s     | 0.0s                |
| minikube in cluster minikube               |          |                     |
| * Creating kvm2 VM (CPUs=2,                | 40.5s    | 40.1s               |
| Memory=3700MB, Disk=20000MB)               |          |                     |
| ...                                        |          |                     |
| * Preparing Kubernetes v1.20.2             | 16.1s    | 2.0s                |
| on Docker 20.10.3 ...                      |          |                     |
|   - Generating certificates                | 1.2s     | 4.3s                |
| and keys ...                               |          |                     |
|   - Booting up control plane               | 5.2s     | 15.3s               |
| ...                                        |          |                     |
|   - Configuring RBAC rules ...             | 0.9s     | 1.5s                |
| * Verifying Kubernetes                     | 0.1s     | 0.1s                |
| components...                              |          |                     |
|   - Using image                            | 1.4s     | 1.4s                |
| gcr.io/k8s-minikube/storage-provisioner:v4 |          |                     |
| * Enabled addons:                          | 0.9s     | 0.8s                |
| storage-provisioner,                       |          |                     |
| default-storageclass                       |          |                     |
| * Done! kubectl is now                     | 0.0s     | 0.0s                |
| configured to use "minikube"               |          |                     |
| cluster and "default"                      |          |                     |
| namespace by default                       |          |                     |
+--------------------------------------------+----------+---------------------+

docker Driver
Times for minikube: 27.5s 27.7s 34.4s
Average time for minikube: 29.9s

Times for Minikube (PR 10868): 27.6s 28.6s 33.7s
Average time for Minikube (PR 10868): 30.0s

Averages Time Per Log

Details 
+--------------------------------------------+----------+---------------------+
|                    LOG                     | MINIKUBE | MINIKUBE (PR 10868) |
+--------------------------------------------+----------+---------------------+
| * minikube v1.18.1 on Debian               | 0.2s     | 0.2s                |
| 9.11 (kvm/amd64)                           |          |                     |
| * Using the docker driver                  | 0.1s     | 0.1s                |
| based on user configuration                |          |                     |
| * Starting control plane node              | 0.1s     | 0.1s                |
| minikube in cluster minikube               |          |                     |
| * Creating docker container                | 12.3s    | 11.7s               |
| (CPUs=2, Memory=3700MB) ...                |          |                     |
| * Preparing Kubernetes v1.20.2             | 15.7s    | 16.3s               |
| on Docker 20.10.3 ...                      |          |                     |
| * Verifying Kubernetes                     | 0.1s     | 0.1s                |
| components...                              |          |                     |
|   - Using image                            | 1.3s     | 1.4s                |
| gcr.io/k8s-minikube/storage-provisioner:v4 |          |                     |
| * Enabled addons:                          | 0.1s     | 0.1s                |
| storage-provisioner,                       |          |                     |
| default-storageclass                       |          |                     |
| * Done! kubectl is now                     | 0.0s     | 0.0s                |
| configured to use "minikube"               |          |                     |
| cluster and "default"                      |          |                     |
| namespace by default                       |          |                     |
+--------------------------------------------+----------+---------------------+

@medyagh medyagh merged commit 6496ab5 into kubernetes:master Mar 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@medyagh medyagh medyagh approved these changes

@prasadkatti prasadkatti Awaiting requested review from prasadkatti

@RA489 RA489 Awaiting requested review from RA489

@ilya-zuyev ilya-zuyev Awaiting requested review from ilya-zuyev

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. pr_verified size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@afbjorklund @k8s-ci-robot @medyagh @minikube-pr-bot @ilya-zuyev