Skip to content

Add minikube image commands for pull and tag and push#12326

Merged
medyagh merged 2 commits intokubernetes:masterfrom
afbjorklund:image-commands
Aug 23, 2021
Merged

Add minikube image commands for pull and tag and push#12326
medyagh merged 2 commits intokubernetes:masterfrom
afbjorklund:image-commands

Conversation

@afbjorklund
Copy link
Copy Markdown
Collaborator

@afbjorklund afbjorklund commented Aug 22, 2021 •
edited
Loading

There are lots of copy and paste in these, so the whole "image" and "machine" is due for an overhaul.

There are also no tests that they actually work, but they are normally not called separately by the user...

Closes #12323

See #12270 (comment)

@afbjorklund
Add stand-alone image pull and image tag commands
380b846 
Needed for testing, but maybe elsewhere as well
@afbjorklund
Add also stand-alone image push matching pull
817f8b4 
Normally this is done as part of image build
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 22, 2021
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 22, 2021
@medyagh
Copy link
Copy Markdown
Member

medyagh commented Aug 23, 2021

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Aug 23, 2021
@minikube-pr-bot
Copy link
Copy Markdown

minikube-pr-bot commented Aug 23, 2021

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12326) |
+----------------+----------+---------------------+
| minikube start | 52.8s    | 52.7s               |
| enable ingress | 39.7s    | 38.3s               |
+----------------+----------+---------------------+
Details

Times for minikube start: 55.4s 50.7s 52.0s 51.2s 54.7s
Times for minikube (PR 12326) start: 51.2s 53.1s 54.6s 52.5s 52.0s

Times for minikube ingress: 32.4s 40.5s 40.3s 42.4s 43.0s
Times for minikube (PR 12326) ingress: 41.9s 32.0s 41.4s 33.4s 42.9s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12326) |
+----------------+----------+---------------------+
| minikube start | 23.4s    | 22.9s               |
| enable ingress | 34.8s    | 35.5s               |
+----------------+----------+---------------------+
Details

Times for minikube start: 24.0s 23.8s 22.4s 24.0s 22.6s
Times for minikube (PR 12326) start: 23.8s 22.1s 23.0s 22.7s 23.1s

Times for minikube ingress: 36.0s 33.6s 40.5s 32.0s 32.1s
Times for minikube (PR 12326) ingress: 32.1s 36.0s 33.6s 38.1s 37.5s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12326) |
+----------------+----------+---------------------+
| minikube start | 43.5s    | 38.6s               |
| enable ingress |          |                     |
+----------------+----------+---------------------+
Details

Times for minikube start: 33.0s 48.3s 43.4s 48.9s 44.0s
Times for minikube (PR 12326) start: 32.0s 42.5s 43.9s 44.2s 30.4s

@minikube-pr-bot
Copy link
Copy Markdown

minikube-pr-bot commented Aug 23, 2021

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Docker_Windows TestPause/serial/Unpause (gopogh) 0.00 (chart)
Docker_Windows TestAddons/parallel/CSI (gopogh) 3.85 (chart)
Docker_Linux_crio_arm64 TestFunctional/parallel/BuildImage (gopogh) 8.57 (chart)
Docker_Windows TestMultiNode/serial/RestartMultiNode (gopogh) 9.23 (chart)
Docker_Linux_crio_arm64 TestStartStop/group/old-k8s-version/serial/DeployApp (gopogh) 10.00 (chart)
Docker_Windows TestFunctional/parallel/InternationalLanguage (gopogh) 12.69 (chart)
Docker_Windows TestFunctional/parallel/TunnelCmd/serial/WaitService/IngressIP (gopogh) 12.69 (chart)
Docker_Windows TestSkaffold (gopogh) 12.69 (chart)
Docker_Linux_crio_arm64 TestStartStop/group/no-preload/serial/FirstStart (gopogh) 13.75 (chart)
Hyperkit_macOS TestStartStop/group/no-preload/serial/DeployApp (gopogh) 14.29 (chart)
Docker_Linux_crio_arm64 TestStartStop/group/no-preload/serial/SecondStart (gopogh) 16.46 (chart)
Docker_Linux_crio_arm64 TestStartStop/group/embed-certs/serial/EnableAddonWhileActive (gopogh) 17.50 (chart)
Docker_Windows TestScheduledStopWindows (gopogh) 22.39 (chart)
Docker_Windows TestAddons/parallel/HelmTiller (gopogh) 23.08 (chart)
Docker_Linux_crio TestStartStop/group/default-k8s-different-port/serial/Stop (gopogh) 25.16 (chart)
Docker_Windows TestInsufficientStorage (gopogh) 29.10 (chart)
Docker_Linux_crio_arm64 TestStartStop/group/embed-certs/serial/DeployApp (gopogh) 30.00 (chart)
Docker_Linux_crio_arm64 TestStartStop/group/no-preload/serial/DeployApp (gopogh) 30.86 (chart)
Docker_Linux_crio_arm64 TestStartStop/group/no-preload/serial/UserAppExistsAfterStop (gopogh) 31.25 (chart)
Docker_macOS TestFunctional/serial/ComponentHealth (gopogh) 31.58 (chart)
Docker_macOS TestFunctional/serial/ExtraConfig (gopogh) 31.58 (chart)
KVM_Linux_crio TestJSONOutput/stop/parallel/DistinctCurrentSteps (gopogh) 34.42 (chart)
KVM_Linux_crio TestJSONOutput/stop/parallel/IncreasingCurrentSteps (gopogh) 34.42 (chart)
Docker_Windows TestMultiNode/serial/CopyFile (gopogh) 37.31 (chart)
Docker_Linux_crio_arm64 TestStartStop/group/default-k8s-different-port/serial/DeployApp (gopogh) 38.82 (chart)
Docker_Windows TestFunctional/parallel/DryRun (gopogh) 42.54 (chart)
Docker_Linux_crio_arm64 TestNetworkPlugins/group/auto/Start (gopogh) 44.64 (chart)
Docker_macOS TestNetworkPlugins/group/kubenet/Start (gopogh) 45.71 (chart)
Docker_Linux_crio_arm64 TestFunctional/parallel/TunnelCmd/serial/WaitService/Setup (gopogh) 51.52 (chart)
Docker_Linux_crio_arm64 TestAddons/parallel/CSI (gopogh) 52.14 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

@medyagh medyagh merged commit 02e909e into kubernetes:master Aug 23, 2021
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Aug 23, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afbjorklund, medyagh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [afbjorklund,medyagh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@medyagh medyagh medyagh approved these changes

@sharifelgamal sharifelgamal Awaiting requested review from sharifelgamal

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add explicit pull and tag and push to the minikube image command

4 participants

@afbjorklund @medyagh @minikube-pr-bot @k8s-ci-robot