Skip to content

feat: Use new bridge interface name on OSX Monterey#12799

Merged
spowelljr merged 1 commit intokubernetes:masterfrom
bakjos:master
Oct 27, 2021
Merged

feat: Use new bridge interface name on OSX Monterey#12799
spowelljr merged 1 commit intokubernetes:masterfrom
bakjos:master

Conversation

@bakjos
Copy link
Copy Markdown
Contributor

@bakjos bakjos commented Oct 27, 2021

This PR modifies the regex to set up the bridge when using hyperkit driver, the current regex generates the following error

router: couldn't find member in bridge100 interface: bridge100: flags=8a63<UP,BROADCAST,SMART,RUNNING,ALLMULTI,SIMPLEX,MULTICAST> mtu 1500
	options=3<RXCSUM,TXCSUM>
	ether 16:7d:da:f9:de:64
	inet 192.168.64.1 netmask 0xffffff00 broadcast 192.168.64.255
	inet6 fe80::147d:daff:fef9:de64%bridge100 prefixlen 64 scopeid 0x12
	inet6 fd9b:f4ec:fbe9:a53:e9:a0a6:61b2:16e prefixlen 64 autoconf secured
	Configuration:
		id 0:0:0:0:0:0 priority 0 hellotime 0 fwddelay 0
		maxage 0 holdcnt 0 proto stp maxaddr 100 timeout 1200
		root id 0:0:0:0:0:0 priority 0 ifcost 0 port 0
		ipfilter disabled flags 0x0
	member: vmenet0 flags=3<LEARNING,DISCOVER>
	        ifmaxaddr 0 port 17 priority 0 path cost 0
	Address cache:
		72:d6:65:d8:a1:4f Vlan1 vmenet0 1200 flags=0<>
	nd6 options=201<PERFORMNUD,DAD>
	media: autoselect
	status: active

Because the member name was changed from en0 to vmenet0

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 27, 2021
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Oct 27, 2021

Welcome @bakjos!

It looks like this is your first PR to kubernetes/minikube 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/minikube has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Oct 27, 2021

Hi @bakjos. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 27, 2021
@minikube-bot
Copy link
Copy Markdown
Collaborator

minikube-bot commented Oct 27, 2021

Can one of the admins verify this patch?

@spowelljr
Copy link
Copy Markdown
Member

spowelljr commented Oct 27, 2021

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 27, 2021
@minikube-pr-bot
Copy link
Copy Markdown

minikube-pr-bot commented Oct 27, 2021

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12799) |
+----------------+----------+---------------------+
| minikube start | 47.3s    | 46.7s               |
| enable ingress | 32.3s    | 32.0s               |
+----------------+----------+---------------------+
Details

Times for minikube ingress: 33.3s 32.8s 32.7s 31.9s 30.9s
Times for minikube (PR 12799) ingress: 31.2s 32.0s 31.9s 32.7s 32.4s

Times for minikube start: 46.5s 47.2s 46.6s 48.1s 48.3s
Times for minikube (PR 12799) start: 48.8s 46.1s 46.9s 46.0s 45.6s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12799) |
+----------------+----------+---------------------+
| minikube start | 21.7s    | 22.2s               |
| enable ingress | 29.2s    | 33.1s               |
+----------------+----------+---------------------+
Details

Times for minikube ingress: 27.4s 28.4s 27.4s 35.4s 27.5s
Times for minikube (PR 12799) ingress: 31.4s 35.4s 34.9s 35.9s 27.9s

Times for minikube start: 21.5s 21.4s 21.7s 22.2s 21.6s
Times for minikube (PR 12799) start: 22.7s 21.8s 22.3s 21.9s 22.2s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12799) |
+----------------+----------+---------------------+
| minikube start | 44.1s    | 43.6s               |
| enable ingress | 41.2s    | 29.5s               |
+----------------+----------+---------------------+
Details

Times for minikube (PR 12799) start: 44.2s 42.9s 43.9s 43.3s 43.9s
Times for minikube start: 42.7s 43.2s 44.7s 43.3s 46.9s

Times for minikube ingress: 34.0s 33.9s 36.9s 67.9s 33.4s
Times for minikube (PR 12799) ingress: 19.9s 22.9s 37.9s 37.9s 28.9s

@spowelljr spowelljr merged commit 1b3d18d into kubernetes:master Oct 27, 2021
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Oct 27, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bakjos, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 27, 2021
@minikube-pr-bot
Copy link
Copy Markdown

minikube-pr-bot commented Oct 27, 2021

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Docker_Linux TestNetworkPlugins/group/auto/Start (gopogh) 0.66 (chart)
Docker_Linux_containerd TestScheduledStopUnix (gopogh) 100.00 (chart)

To see the flake rates of all tests by environment, click here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@spowelljr spowelljr spowelljr approved these changes

@prezha prezha Awaiting requested review from prezha

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@bakjos @k8s-ci-robot @minikube-bot @spowelljr @minikube-pr-bot