Skip to content

fix zsh completion#12841

Merged
medyagh merged 1 commit intokubernetes:masterfrom
Keyhoh:issue/refix-11348
Nov 2, 2021
Merged

fix zsh completion#12841
medyagh merged 1 commit intokubernetes:masterfrom
Keyhoh:issue/refix-11348

Conversation

@Keyhoh
Copy link
Copy Markdown
Contributor

@Keyhoh Keyhoh commented Nov 2, 2021 •
edited
Loading

my previous fix is wrong
zsh completion is not working in v1.24.0-beta.0
revert wrong change (#12420) and re-fix

before PR (v1.24.0-beta.0)
tab completion does not work

$ out/minikube version
minikube version: v1.24.0-beta.0
commit: 06b3f0a03b012632c86627e227cfeb29b12aed5c
$ out/minikube completion zsh > before.completion.txt

before.completion.txt
Screenshot from 2021-11-03 02-47-40

after PR
completion works

$ out/minikube version
minikube version: v1.24.0-beta.0
commit: ca928b43ed86ed65056700dba67ec1a5e0b5714e
$ out/minikube completion zsh > after.completion.txt

after.completion.txt
Screenshot from 2021-11-03 02-45-25

stable release
completion is broken

$ out/minikube version
minikube version: v1.23.2
commit:  0a0ad764652082477c00d51d2475284b5d39ceed
$ out/minikube completion zsh > v1.23.completion.txt

v1.23.completion.txt
Screenshot from 2021-11-03 02-49-49

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 2, 2021
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Nov 2, 2021

Hi @Keyhoh. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 2, 2021
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Nov 2, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Keyhoh
To complete the pull request process, please assign prezha after the PR has been reviewed.
You can assign the PR to them by writing /assign @prezha in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@minikube-bot
Copy link
Copy Markdown
Collaborator

minikube-bot commented Nov 2, 2021

Can one of the admins verify this patch?

medyagh
medyagh reviewed Nov 2, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@medyagh medyagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Keyhoh there is no way for me to test this,
would u plz share the output of minikube in the PR description ? before and after this PR ?

@Keyhoh Keyhoh requested a review from medyagh November 2, 2021 17:40
@Keyhoh
Copy link
Copy Markdown
Contributor Author

Keyhoh commented Nov 2, 2021 •
edited
Loading

thanks @medyagh !
description updated!

@medyagh medyagh changed the title fix: revert wrong fix and re-fix zsh completion fix zsh completion Nov 2, 2021
@medyagh medyagh merged commit 9dde4cb into kubernetes:master Nov 2, 2021
@medyagh
Copy link
Copy Markdown
Member

medyagh commented Nov 2, 2021

thank you @Keyhoh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@prasadkatti prasadkatti Awaiting requested review from prasadkatti

@sharifelgamal sharifelgamal Awaiting requested review from sharifelgamal

@medyagh medyagh Awaiting requested review from medyagh

Assignees

No one assigned

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Keyhoh @k8s-ci-robot @minikube-bot @medyagh