Skip to content

ISO: Upgrade falco-module to version 0.31.0#13659

Merged
spowelljr merged 4 commits intokubernetes:masterfrom
afbjorklund:falco-0.31.0
Apr 11, 2022
Merged

ISO: Upgrade falco-module to version 0.31.0#13659
spowelljr merged 4 commits intokubernetes:masterfrom
afbjorklund:falco-0.31.0

Conversation

@afbjorklund
Copy link
Copy Markdown
Collaborator

@afbjorklund afbjorklund commented Feb 22, 2022

Needed a rename, from sysdig to falcosecurity-libs

Replaces #13331

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 22, 2022
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 22, 2022
@afbjorklund

This comment was marked as outdated.

Sign in to view
@minikube-bot

This comment was marked as outdated.

Sign in to view
@afbjorklund

This comment was marked as outdated.

Sign in to view
@minikube-bot

This comment was marked as outdated.

Sign in to view
1 similar comment
@minikube-bot

This comment was marked as outdated.

Sign in to view
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 24, 2022
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 24, 2022
@sharifelgamal

This comment was marked as outdated.

Sign in to view
@minikube-bot

This comment was marked as outdated.

Sign in to view
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 26, 2022
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 2, 2022
@minikube-bot

This comment was marked as outdated.

Sign in to view
@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Mar 29, 2022
@spowelljr
Copy link
Copy Markdown
Member

spowelljr commented Mar 31, 2022

ok-to-build-iso

@minikube-bot

This comment was marked as outdated.

Sign in to view
@spowelljr
Copy link
Copy Markdown
Member

spowelljr commented Mar 31, 2022

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Mar 31, 2022
@minikube-pr-bot

This comment was marked as outdated.

Sign in to view
@minikube-pr-bot

This comment was marked as outdated.

Sign in to view
@spowelljr
Copy link
Copy Markdown
Member

spowelljr commented Apr 4, 2022

/retest-this-please

@minikube-pr-bot

This comment was marked as outdated.

Sign in to view
@minikube-pr-bot

This comment was marked as outdated.

Sign in to view
@afbjorklund
Copy link
Copy Markdown
Collaborator Author

afbjorklund commented Apr 10, 2022

ok-to-build-iso

@minikube-bot
Copy link
Copy Markdown
Collaborator

minikube-bot commented Apr 10, 2022

Hi @afbjorklund, we have updated your PR with the reference to newly built ISO. Pull the changes locally if you want to test with them or update your PR further.

@minikube-pr-bot
Copy link
Copy Markdown

minikube-pr-bot commented Apr 10, 2022

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13659) |
+----------------+----------+---------------------+
| minikube start | 50.9s    | 50.5s               |
| enable ingress | 28.9s    | 29.3s               |
+----------------+----------+---------------------+
Details

Times for minikube start: 51.4s 51.9s 50.7s 50.2s 50.0s
Times for minikube (PR 13659) start: 50.0s 50.9s 50.8s 51.0s 49.9s

Times for minikube ingress: 29.6s 29.1s 30.0s 29.5s 26.5s
Times for minikube (PR 13659) ingress: 29.0s 29.0s 30.0s 29.5s 29.0s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13659) |
+----------------+----------+---------------------+
| minikube start | 24.4s    | 24.4s               |
| enable ingress | 24.1s    | 24.2s               |
+----------------+----------+---------------------+
Details

Times for minikube start: 24.5s 24.2s 23.9s 24.7s 24.9s
Times for minikube (PR 13659) start: 25.0s 24.3s 23.9s 24.4s 24.6s

Times for minikube ingress: 23.9s 22.9s 25.4s 26.4s 21.9s
Times for minikube (PR 13659) ingress: 22.4s 26.9s 26.4s 22.9s 22.4s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13659) |
+----------------+----------+---------------------+
| minikube start | 38.4s    | 37.1s               |
| enable ingress | 24.8s    | 23.4s               |
+----------------+----------+---------------------+
Details

Times for minikube start: 29.3s 39.6s 43.5s 39.5s 40.1s
Times for minikube (PR 13659) start: 38.7s 39.2s 39.5s 27.9s 40.2s

Times for minikube ingress: 23.4s 22.4s 28.4s 26.4s 23.4s
Times for minikube (PR 13659) ingress: 23.4s 22.4s 26.4s 22.4s 22.4s

@minikube-pr-bot
Copy link
Copy Markdown

minikube-pr-bot commented Apr 10, 2022

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Docker_macOS TestDownloadOnly/v1.23.6-rc.0/preload-exists (gopogh) 1.57 (chart)
Docker_Linux_containerd TestNetworkPlugins/group/cilium/Start (gopogh) 4.00 (chart)
Docker_macOS TestDownloadOnlyKic (gopogh) 8.44 (chart)
Docker_macOS TestDownloadOnly/v1.23.5/preload-exists (gopogh) 9.49 (chart)
Docker_Linux_containerd TestAddons/parallel/Registry (gopogh) 9.85 (chart)
Docker_Linux_containerd TestNetworkPlugins/group/auto/Start (gopogh) 10.32 (chart)
Docker_Linux_containerd TestOffline (gopogh) 20.86 (chart)
Docker_Linux_containerd TestPause/serial/Start (gopogh) 21.47 (chart)
Docker_Linux_containerd TestFunctional/parallel/DashboardCmd (gopogh) 26.99 (chart)
Docker_Linux_containerd TestFunctional/parallel/MountCmd/any-port (gopogh) 26.99 (chart)
Docker_Linux_containerd TestFunctional/parallel/MySQL (gopogh) 26.99 (chart)
Docker_Linux_containerd TestFunctional/parallel/PersistentVolumeClaim (gopogh) 26.99 (chart)
Docker_Linux_containerd TestFunctional/parallel/ServiceCmd (gopogh) 26.99 (chart)
Docker_Linux_containerd TestFunctional/parallel/ServiceCmdConnect (gopogh) 26.99 (chart)
Docker_Linux_containerd TestFunctional/parallel/TunnelCmd/serial/AccessDirect (gopogh) 26.99 (chart)
Docker_Linux_containerd TestFunctional/parallel/TunnelCmd/serial/WaitService/Setup (gopogh) 26.99 (chart)
Docker_Linux_containerd TestFunctional/serial/ExtraConfig (gopogh) 26.99 (chart)
Docker_Linux_containerd TestFunctional/serial/SoftStart (gopogh) 26.99 (chart)
Docker_Linux_containerd TestFunctional/serial/StartWithProxy (gopogh) 26.99 (chart)
Docker_Linux_containerd TestMultiNode/serial/DeployApp2Nodes (gopogh) 26.99 (chart)
Docker_Linux_containerd TestMultiNode/serial/PingHostFrom2Pods (gopogh) 26.99 (chart)
Docker_Linux_containerd TestStartStop/group/embed-certs/serial/UserAppExistsAfterStop (gopogh) 38.89 (chart)
Docker_macOS TestNetworkPlugins/group/custom-weave/Start (gopogh) 46.15 (chart)
Docker_macOS TestFunctional/serial/ComponentHealth (gopogh) 47.06 (chart)
Docker_macOS TestFunctional/serial/ExtraConfig (gopogh) 47.06 (chart)
Docker_macOS TestStartStop/group/default-k8s-different-port/serial/SecondStart (gopogh) 50.54 (chart)
Docker_Linux_containerd TestNetworkPlugins/group/kindnet/Start (gopogh) 52.00 (chart)
Docker_macOS TestNetworkPlugins/group/kubenet/DNS (gopogh) 57.81 (chart)
Docker_macOS TestNetworkPlugins/group/kindnet/Start (gopogh) 58.46 (chart)
Docker_Linux_containerd TestNetworkPlugins/group/calico/DNS (gopogh) 65.00 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

@minikube-pr-bot
Copy link
Copy Markdown

minikube-pr-bot commented Apr 10, 2022

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13659) |
+----------------+----------+---------------------+
| minikube start | 51.9s    | 51.8s               |
| enable ingress | 28.7s    | 28.9s               |
+----------------+----------+---------------------+
Details

Times for minikube (PR 13659) start: 50.0s 54.5s 50.7s 52.1s 51.8s
Times for minikube start: 55.0s 50.8s 51.3s 51.2s 51.1s

Times for minikube ingress: 28.1s 29.6s 29.0s 28.1s 28.6s
Times for minikube (PR 13659) ingress: 29.6s 30.1s 30.1s 25.5s 29.1s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13659) |
+----------------+----------+---------------------+
| minikube start | 25.4s    | 24.4s               |
| enable ingress | 22.3s    | 22.2s               |
+----------------+----------+---------------------+
Details

Times for minikube start: 27.2s 24.7s 24.9s 25.8s 24.4s
Times for minikube (PR 13659) start: 24.2s 24.3s 24.5s 25.2s 23.8s

Times for minikube ingress: 21.9s 22.9s 21.9s 21.9s 22.9s
Times for minikube (PR 13659) ingress: 22.9s 21.9s 21.9s 21.9s 22.4s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13659) |
+----------------+----------+---------------------+
| minikube start | 38.7s    | 41.3s               |
| enable ingress | 18.7s    | 19.9s               |
+----------------+----------+---------------------+
Details

Times for minikube (PR 13659) start: 43.2s 40.2s 39.3s 43.6s 40.0s
Times for minikube start: 34.0s 31.9s 43.3s 45.1s 39.2s

Times for minikube ingress: 17.9s 16.9s 18.4s 17.9s 22.4s
Times for minikube (PR 13659) ingress: 16.9s 21.4s 21.4s 17.4s 22.4s

@minikube-pr-bot
Copy link
Copy Markdown

minikube-pr-bot commented Apr 10, 2022

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
none_Linux TestFunctional/parallel/DashboardCmd (gopogh) 1.86 (chart)
Docker_macOS TestFunctional/parallel/DashboardCmd (gopogh) 12.99 (chart)
Docker_macOS TestNoKubernetes/serial/StartWithStopK8s (gopogh) 18.42 (chart)
Docker_Linux TestAddons/parallel/Registry (gopogh) 20.00 (chart)
Docker_Linux TestFunctional/parallel/DashboardCmd (gopogh) 20.00 (chart)
Docker_Linux TestFunctional/parallel/PersistentVolumeClaim (gopogh) 20.00 (chart)
Docker_Linux TestMultiNode/serial/DeployApp2Nodes (gopogh) 20.00 (chart)
Docker_Linux TestMultiNode/serial/PingHostFrom2Pods (gopogh) 20.00 (chart)
Docker_Linux TestNetworkPlugins/group/auto/DNS (gopogh) 27.74 (chart)
Docker_Linux TestNetworkPlugins/group/false/DNS (gopogh) 40.00 (chart)
Docker_macOS TestFunctional/serial/ComponentHealth (gopogh) 46.75 (chart)
Docker_macOS TestFunctional/serial/ExtraConfig (gopogh) 46.75 (chart)
Docker_macOS TestStartStop/group/default-k8s-different-port/serial/SecondStart (gopogh) 51.06 (chart)
Hyper-V_Windows TestNoKubernetes/serial/StartWithK8s (gopogh) 58.57 (chart)
Docker_Linux TestNetworkPlugins/group/custom-weave/Start (gopogh) 63.23 (chart)
Docker_Linux TestNetworkPlugins/group/kindnet/DNS (gopogh) 64.86 (chart)
Docker_Linux TestNetworkPlugins/group/calico/Start (gopogh) 73.55 (chart)
Docker_Linux TestNetworkPlugins/group/enable-default-cni/DNS (gopogh) 82.58 (chart)
Docker_Linux TestNetworkPlugins/group/bridge/DNS (gopogh) 83.23 (chart)
Docker_Linux TestNetworkPlugins/group/kubenet/DNS (gopogh) 85.16 (chart)
Docker_macOS TestDownloadOnly/v1.16.0/preload-exists (gopogh) 99.35 (chart)
Hyper-V_Windows TestMultiNode/serial/PingHostFrom2Pods (gopogh) 100.00 (chart)
Hyper-V_Windows TestMultiNode/serial/RestartKeepsNodes (gopogh) 100.00 (chart)
Hyper-V_Windows TestSkaffold (gopogh) 100.00 (chart)

To see the flake rates of all tests by environment, click here.

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Apr 11, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afbjorklund, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [afbjorklund,spowelljr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@spowelljr spowelljr merged commit 0ab2051 into kubernetes:master Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@spowelljr spowelljr spowelljr approved these changes

@klaases klaases Awaiting requested review from klaases

@medyagh medyagh Awaiting requested review from medyagh

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@afbjorklund @minikube-bot @sharifelgamal @spowelljr @minikube-pr-bot @k8s-ci-robot