The committers listed above are authorized under a signed CLA.

• ✅ login: yolossn / name: S Santhosh Nagaraj (1fdd8db)

Welcome @yolossn!

It looks like this is your first PR to kubernetes/minikube 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/minikube has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

Hi @yolossn. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Can one of the admins verify this patch?

Thanks for the PR, it looks good, but could you add an integration test that ensures the pods you're expecting come up. This will help us detect if the addon starts failing with a Kubernetes update or anything else that could cause it to fail.

https://github.com/kubernetes/minikube/blob/master/test/integration/addons_test.go

@spowelljr Added the integration test as suggested, Can you PTAL ?

/ok-to-test

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 14315) |
+----------------+----------+---------------------+
| minikube start | 50.9s    | 50.1s               |
| enable ingress | 27.7s    | 28.1s               |
+----------------+----------+---------------------+

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 14315) |
+----------------+----------+---------------------+
| minikube start | 28.8s    | 24.9s               |
| enable ingress | 22.1s    | 21.5s               |
+----------------+----------+---------------------+

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 14315) |
+----------------+----------+---------------------+
| minikube start | 32.7s    | 30.6s               |
| enable ingress | 19.2s    | 22.4s               |
+----------------+----------+---------------------+

Hey @spowelljr I looked into why some of the checks are failing and it doesn't seem to be related to the changes, Do you think a rerun will help in this case? Or is there something that I am missing?

Hi @yolossn, we have several flakey tests so we expect many to fail. We're having an issue with our Docker Linux CI right now, so once we get that fixed I'll rerun the tests.

Hi @yolossn, could you pull the latest master of minikube and then rebase your PR, that will pull in the CI fix and will rerun your tests, thanks

Hi @yolossn, could you pull the latest master of minikube and then rebase your PR, that will pull in the CI fix and will rerun your tests, thanks

Done 👍🏽

These are the flake rates of all failed tests.

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

/retest-this-please

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 14315) |
+----------------+----------+---------------------+
| minikube start | 50.8s    | 51.9s               |
| enable ingress | 28.5s    | 28.1s               |
+----------------+----------+---------------------+

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 14315) |
+----------------+----------+---------------------+
| minikube start | 25.0s    | 25.2s               |
| enable ingress | 22.9s    | 23.4s               |
+----------------+----------+---------------------+

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 14315) |
+----------------+----------+---------------------+
| minikube start | 33.5s    | 29.9s               |
| enable ingress | 22.5s    | 25.9s               |
+----------------+----------+---------------------+

@spowelljr Gentle ping, Some tests still failed after rebase.

The tests look good to me @yolossn

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: spowelljr, yolossn

The full list of commands accepted by this bot can be found here.

The pull request process is described here