Skip to content

Check if context is invalid during update-context#15032

Merged
spowelljr merged 1 commit intokubernetes:masterfrom
spowelljr:fixUpdateContext
Sep 30, 2022
Merged

Check if context is invalid during update-context#15032
spowelljr merged 1 commit intokubernetes:masterfrom
spowelljr:fixUpdateContext

Conversation

@spowelljr
Copy link
Copy Markdown
Member

@spowelljr spowelljr commented Sep 28, 2022 •
edited
Loading

Closes #15039

Previously only the cluster was checked when minikube update-context was called. Now the context is checked as well, and if either is invalid it recreates the entries.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 28, 2022
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 28, 2022
@medyagh
Copy link
Copy Markdown
Member

medyagh commented Sep 29, 2022

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Sep 29, 2022
@minikube-pr-bot
Copy link
Copy Markdown

minikube-pr-bot commented Sep 29, 2022

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15032) |
+----------------+----------+---------------------+
| minikube start | 55.2s    | 56.2s               |
| enable ingress | 26.5s    | 26.3s               |
+----------------+----------+---------------------+
Details

Times for minikube ingress: 24.1s 25.6s 24.6s 29.1s 29.1s
Times for minikube (PR 15032) ingress: 25.1s 29.1s 28.6s 25.1s 23.7s

Times for minikube start: 55.6s 54.2s 55.7s 55.9s 54.5s
Times for minikube (PR 15032) start: 56.6s 56.7s 53.9s 55.7s 57.9s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15032) |
+----------------+----------+---------------------+
| minikube start | 27.4s    | 27.9s               |
| enable ingress | 23.6s    | 23.1s               |
+----------------+----------+---------------------+
Details

Times for minikube (PR 15032) start: 28.2s 28.0s 27.5s 27.5s 28.6s
Times for minikube start: 26.9s 27.4s 28.3s 27.4s 27.1s

Times for minikube ingress: 26.5s 23.0s 23.5s 21.5s 23.5s
Times for minikube (PR 15032) ingress: 23.5s 23.5s 22.5s 22.5s 23.5s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15032) |
+----------------+----------+---------------------+
| minikube start | 25.5s    | 25.4s               |
| enable ingress | 27.4s    | 27.1s               |
+----------------+----------+---------------------+
Details

Times for minikube start: 22.9s 22.3s 36.8s 22.9s 22.9s
Times for minikube (PR 15032) start: 33.6s 23.4s 22.9s 23.2s 24.1s

Times for minikube ingress: 27.5s 27.5s 27.0s 27.5s 27.5s
Times for minikube (PR 15032) ingress: 27.0s 26.9s 27.0s 27.0s 27.4s

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Sep 29, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@minikube-pr-bot
Copy link
Copy Markdown

minikube-pr-bot commented Sep 30, 2022

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Hyper-V_Windows TestStartStop/group/default-k8s-different-port/serial/Pause (gopogh) 0.00 (chart)
Hyper-V_Windows TestNetworkPlugins/group/flannel/ControllerPod (gopogh) 0.80 (chart)
Docker_Linux_containerd TestNetworkPlugins/group/kindnet/Start (gopogh) 10.43 (chart)
Hyper-V_Windows TestNetworkPlugins/group/bridge/Start (gopogh) 16.55 (chart)
Hyper-V_Windows TestNetworkPlugins/group/kubenet/Start (gopogh) 23.74 (chart)
Docker_Linux_containerd TestOffline (gopogh) 25.32 (chart)
Docker_Linux_containerd TestAddons/Setup (gopogh) 27.85 (chart)
Docker_Linux_containerd TestFunctional/parallel/DashboardCmd (gopogh) 27.85 (chart)
Docker_Linux_containerd TestFunctional/parallel/MountCmd/any-port (gopogh) 27.85 (chart)
Docker_Linux_containerd TestFunctional/parallel/MySQL (gopogh) 27.85 (chart)
Docker_Linux_containerd TestFunctional/parallel/PersistentVolumeClaim (gopogh) 27.85 (chart)
Docker_Linux_containerd TestFunctional/parallel/ServiceCmd (gopogh) 27.85 (chart)
Docker_Linux_containerd TestFunctional/parallel/ServiceCmdConnect (gopogh) 27.85 (chart)
Docker_Linux_containerd TestFunctional/parallel/TunnelCmd/serial/AccessDirect (gopogh) 27.85 (chart)
Docker_Linux_containerd TestFunctional/parallel/TunnelCmd/serial/WaitService/Setup (gopogh) 27.85 (chart)
Docker_Linux_containerd TestFunctional/serial/ExtraConfig (gopogh) 27.85 (chart)
Docker_Linux_containerd TestFunctional/serial/SoftStart (gopogh) 27.85 (chart)
Docker_Linux_containerd TestFunctional/serial/StartWithProxy (gopogh) 27.85 (chart)
Docker_Linux_containerd TestIngressAddonLegacy/serial/ValidateIngressAddonActivation (gopogh) 27.85 (chart)
Docker_Linux_containerd TestIngressAddonLegacy/StartLegacyK8sCluster (gopogh) 27.85 (chart)
Docker_Linux_containerd TestJSONOutput/start/Command (gopogh) 27.85 (chart)
Docker_Linux_containerd TestMultiNode/serial/AddNode (gopogh) 27.85 (chart)
Docker_Linux_containerd TestMultiNode/serial/DeployApp2Nodes (gopogh) 27.85 (chart)
Docker_Linux_containerd TestMultiNode/serial/FreshStart2Nodes (gopogh) 27.85 (chart)
Docker_Linux_containerd TestMultiNode/serial/PingHostFrom2Pods (gopogh) 27.85 (chart)
Docker_Linux_containerd TestMultiNode/serial/ProfileList (gopogh) 27.85 (chart)
Docker_Linux_containerd TestMultiNode/serial/StartAfterStop (gopogh) 27.85 (chart)
Docker_Linux_containerd TestMultiNode/serial/StopNode (gopogh) 27.85 (chart)
Docker_Linux_containerd TestPreload (gopogh) 27.85 (chart)
Docker_Linux_containerd TestMultiNode/serial/RestartMultiNode (gopogh) 28.48 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

@spowelljr spowelljr merged commit 5fba315 into kubernetes:master Sep 30, 2022
@spowelljr spowelljr deleted the fixUpdateContext branch September 30, 2022 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@medyagh medyagh medyagh approved these changes

@blueelvis blueelvis Awaiting requested review from blueelvis

@prasadkatti prasadkatti Awaiting requested review from prasadkatti

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Check if context is invalid during update-context

4 participants

@spowelljr @medyagh @minikube-pr-bot @k8s-ci-robot