Skip to content

ISO: update Docker from 20.10.22 to 20.10.23 #15703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
spowelljr merged 3 commits into from
Jan 25, 2023
Merged

ISO: update Docker from 20.10.22 to 20.10.23 #15703

spowelljr merged 3 commits into from
Jan 25, 2023

Conversation

@spowelljr
Copy link
Member

@spowelljr spowelljr commented Jan 24, 2023

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 24, 2023
@spowelljr
Copy link
Member Author

spowelljr commented Jan 24, 2023

ok-to-build-iso

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 24, 2023
@spowelljr
Copy link
Member Author

spowelljr commented Jan 24, 2023

ok-to-build-image

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jan 24, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@minikube-bot
Copy link
Collaborator

minikube-bot commented Jan 24, 2023

Hi @spowelljr, we have updated your PR with the reference to newly built kicbase image. Pull the changes locally if you want to test with them or update your PR further.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 24, 2023
@minikube-bot
Copy link
Collaborator

minikube-bot commented Jan 25, 2023

Hi @spowelljr, we have updated your PR with the reference to newly built ISO. Pull the changes locally if you want to test with them or update your PR further.

@spowelljr
Copy link
Member Author

spowelljr commented Jan 25, 2023

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jan 25, 2023
@minikube-pr-bot
Copy link

minikube-pr-bot commented Jan 25, 2023

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15703) |
+----------------+----------+---------------------+
| minikube start | 55.6s    | 55.0s               |
| enable ingress | 28.3s    | 25.4s               |
+----------------+----------+---------------------+
Details

Times for minikube start: 55.3s 54.8s 53.8s 59.0s 55.4s
Times for minikube (PR 15703) start: 56.0s 56.1s 54.1s 54.8s 54.0s

Times for minikube ingress: 28.8s 28.3s 27.8s 28.2s 28.2s
Times for minikube (PR 15703) ingress: 26.3s 25.2s 25.3s 25.3s 24.7s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15703) |
+----------------+----------+---------------------+
| minikube start | 26.4s    | 26.0s               |
| enable ingress | 32.9s    | 20.9s               |
+----------------+----------+---------------------+
Details

Times for minikube ingress: 19.5s 81.5s 20.5s 21.0s 22.0s
Times for minikube (PR 15703) ingress: 20.5s 21.5s 20.5s 21.0s 21.0s

Times for minikube (PR 15703) start: 25.5s 25.5s 24.6s 29.4s 25.4s
Times for minikube start: 25.2s 25.7s 26.3s 24.7s 30.0s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15703) |
+----------------+----------+---------------------+
| minikube start | 20.8s    | 22.5s               |
| enable ingress | 38.8s    | 36.7s               |
+----------------+----------+---------------------+
Details

Times for minikube start: 20.3s 20.9s 20.8s 21.1s 21.0s
Times for minikube (PR 15703) start: 23.3s 20.1s 23.1s 21.0s 25.2s

Times for minikube (PR 15703) ingress: 21.5s 79.5s 31.5s 32.5s 18.5s
Times for minikube ingress: 32.0s 31.5s 18.0s 31.5s 81.0s

@minikube-pr-bot
Copy link

minikube-pr-bot commented Jan 25, 2023

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Docker_macOS TestNetworkPlugins/group/custom-flannel/Start (gopogh) 1.61 (chart)
Docker_macOS TestNetworkPlugins/group/flannel/Start (gopogh) 1.61 (chart)
Docker_macOS TestNoKubernetes/serial/Start (gopogh) 3.50 (chart)
Docker_macOS TestNoKubernetes/serial/StartNoArgs (gopogh) 3.50 (chart)
Docker_macOS TestNoKubernetes/serial/StartWithStopK8s (gopogh) 3.50 (chart)
Docker_macOS TestNoKubernetes/serial/Stop (gopogh) 3.50 (chart)
Docker_macOS TestNetworkPlugins/group/auto/Start (gopogh) 3.52 (chart)
Docker_macOS TestNetworkPlugins/group/bridge/Start (gopogh) 3.52 (chart)
Docker_macOS TestNetworkPlugins/group/enable-default-cni/Start (gopogh) 3.52 (chart)
Docker_macOS TestNetworkPlugins/group/false/Start (gopogh) 3.52 (chart)
Docker_macOS TestNetworkPlugins/group/kindnet/Start (gopogh) 3.52 (chart)
Docker_macOS TestNetworkPlugins/group/kubenet/Start (gopogh) 3.52 (chart)
Docker_macOS TestStartStop/group/default-k8s-diff-port/serial/AddonExistsAfterStop (gopogh) 3.55 (chart)
Docker_macOS TestStartStop/group/default-k8s-diff-port/serial/DeployApp (gopogh) 3.55 (chart)
Docker_macOS TestStartStop/group/default-k8s-diff-port/serial/EnableAddonAfterStop (gopogh) 3.55 (chart)
Docker_macOS TestStartStop/group/default-k8s-diff-port/serial/EnableAddonWhileActive (gopogh) 3.55 (chart)
Docker_macOS TestStartStop/group/default-k8s-diff-port/serial/Pause (gopogh) 3.55 (chart)
Docker_macOS TestStartStop/group/default-k8s-diff-port/serial/SecondStart (gopogh) 3.55 (chart)
Docker_macOS TestStartStop/group/default-k8s-diff-port/serial/Stop (gopogh) 3.55 (chart)
Docker_macOS TestStartStop/group/default-k8s-diff-port/serial/UserAppExistsAfterStop (gopogh) 3.55 (chart)
Docker_macOS TestStartStop/group/default-k8s-diff-port/serial/VerifyKubernetesImages (gopogh) 3.55 (chart)
Docker_macOS TestStartStop/group/embed-certs/serial/AddonExistsAfterStop (gopogh) 3.55 (chart)
Docker_macOS TestStartStop/group/embed-certs/serial/DeployApp (gopogh) 3.55 (chart)
Docker_macOS TestStartStop/group/embed-certs/serial/EnableAddonAfterStop (gopogh) 3.55 (chart)
Docker_macOS TestStartStop/group/embed-certs/serial/EnableAddonWhileActive (gopogh) 3.55 (chart)
Docker_macOS TestStartStop/group/embed-certs/serial/FirstStart (gopogh) 3.55 (chart)
Docker_macOS TestStartStop/group/embed-certs/serial/SecondStart (gopogh) 3.55 (chart)
Docker_macOS TestStartStop/group/embed-certs/serial/Stop (gopogh) 3.55 (chart)
Docker_macOS TestStartStop/group/embed-certs/serial/UserAppExistsAfterStop (gopogh) 3.55 (chart)
Docker_macOS TestStartStop/group/embed-certs/serial/VerifyKubernetesImages (gopogh) 3.55 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

@spowelljr spowelljr merged commit 7cddc7e into kubernetes:master Jan 25, 2023
@spowelljr spowelljr deleted the updateDocker branch January 25, 2023 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@medyagh medyagh medyagh approved these changes

@afbjorklund afbjorklund Awaiting requested review from afbjorklund

@sharifelgamal sharifelgamal Awaiting requested review from sharifelgamal

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@spowelljr @k8s-ci-robot @minikube-bot @minikube-pr-bot @medyagh