Update MINIKUBE_HOME usage#18648
Conversation
|
|
|
Can one of the admins verify this patch? |
|
Welcome @tony-sol! |
|
Hi @tony-sol. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/ok-to-test |
|
kvm2 driver with docker runtime DetailsTimes for minikube start: 48.1s 46.9s 48.9s 48.3s 47.0s Times for minikube ingress: 24.5s 27.0s 28.0s 25.0s 24.0s docker driver with docker runtime DetailsTimes for minikube ingress: 21.3s 21.8s 21.8s 22.8s 21.8s Times for minikube start: 23.3s 24.0s 21.0s 23.6s 23.7s docker driver with containerd runtime DetailsTimes for minikube start: 20.4s 18.8s 22.2s 20.3s 23.0s Times for minikube ingress: 32.8s 32.3s 18.8s 32.3s 31.8s |
|
These are the flake rates of all failed tests.
To see the flake rates of all tests by environment, click here. |
spowelljr
left a comment
There was a problem hiding this comment.
Looks good to me, thanks for the PR!
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: spowelljr, tony-sol The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Because minikube changed MINIKUBE_HOME usage[1], chown now fails. To address this, use the minikube function to set permissions. [1]: kubernetes/minikube#18648 Signed-off-by: Toshikuni Fukaya <toshikuni-fukaya@cybozu.co.jp>
Because minikube changed MINIKUBE_HOME usage[1], chown now fails. To address this, use the minikube function to set permissions. [1]: kubernetes/minikube#18648 Signed-off-by: Toshikuni Fukaya <toshikuni-fukaya@cybozu.co.jp>
Resolves #15835
Make
MINIKUBE_HOMEenv variable usage more convenient with backward compatibility.Current logic of
MINIKUBE_HOMEenv usage isn't really obvious:${HOME}/.minikubeas default..minikube- use env var.minikubeto env var value (for some reason??)It's very implicit logic and goes against the conventional use of
*_HOMEenv vars.With this changes, the logic changes a bit:
${HOME}/.minikubeas default (as it's now).minikube- use env var (as it's now).minikubeinside path, provided via env var (for backward compatibility)${MINIKUBE_HOME}/.minikubeexists - use this legacy path (for backward compatibility)MINIKUBE_HOMEas is (new)So, here is example cases:
.minikube:.minikubeAND there is NO.minikubeinside:.minikubeAND there is.minikubeinside provided path: