-
Notifications
You must be signed in to change notification settings - Fork 5.1k
Addon inspektor-gadget: Update inspektor-gadget image from v0.41.0 to v0.42.0 #21038
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Addon inspektor-gadget: Update inspektor-gadget image from v0.41.0 to v0.42.0 #21038
Conversation
25cec74 to
97ad44b
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: minikube-bot The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Hi @minikube-bot. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
kvm2 driver with docker runtime Times for minikube (PR 21038) start: 50.6s 53.2s 51.5s 49.7s 51.1s Times for minikube ingress: 14.5s 15.0s 15.0s 15.1s 16.0s docker driver with docker runtime Times for minikube start: 26.2s 22.1s 22.3s 22.9s 26.4s Times for minikube ingress: 10.8s 13.3s 12.3s 12.8s 12.7s docker driver with containerd runtime Times for minikube start: 22.2s 23.1s 22.6s 22.7s 25.0s Times for minikube ingress: 22.7s 38.8s 23.3s 22.8s 23.8s |
| plural: "" | ||
| conditions: [] | ||
| storedVersions: [] | ||
| 404: Not Found No newline at end of file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Inspektor Gadget removed its CRD (gadget.kinvolk.io_traces.yaml) in v0.42.0 (released in July). See:
inspektor-gadget/inspektor-gadget@1d81a61
Minikube should remove this function updateCRDYAML:
minikube/hack/update/inspektor_gadget_version/inspektor_gadget_version.go
Lines 90 to 103 in 87ccec3
| func updateCRDYAML(version string) { | |
| res, err := http.Get(fmt.Sprintf("https://raw.githubusercontent.com/inspektor-gadget/inspektor-gadget/refs/tags/%s/pkg/resources/crd/bases/gadget.kinvolk.io_traces.yaml", version)) | |
| if err != nil { | |
| klog.Fatalf("failed to get yaml file: %v", err) | |
| } | |
| defer res.Body.Close() | |
| yaml, err := io.ReadAll(res.Body) | |
| if err != nil { | |
| klog.Fatalf("failed to read body: %v", err) | |
| } | |
| if err := os.WriteFile("../deploy/addons/inspektor-gadget/ig-crd.yaml", yaml, 0644); err != nil { | |
| klog.Fatalf("failed to write to YAML file: %v", err) | |
| } | |
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in #21843
The inspektor-gadget project released a new version
This PR was auto-generated by
make update-inspektor-gadget-versionusing update-inspektor-gadget-version.yml CI Workflow.