Skip to content

license: don't fail if output dir doesn't exist & download from github assets first #21206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Aug 2, 2025
Merged

license: don't fail if output dir doesn't exist & download from github assets first #21206

merged 10 commits into from
Aug 2, 2025

Conversation

@medyagh
Copy link
Member

@medyagh medyagh commented Jul 30, 2025 •
edited
Loading

  • release scripts: make sure to upload the licenses.tar to github assets
  • try github assets first and fail over to minikube gcs bucket second
  • also fixes the bug that if directory didnt exist it will would blow up:

Before (with a dir that doesnt exists)

$ mk license -d /tmp/t74

❌  Exiting due to INET_LICENSES: Failed to download licenses: failed to untar licenses: exit status 1

╭──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────╮
│                                                                                                                          │
│    😿  If the above advice does not help, please let us know:                                                            │
│    👉  https://github.com/kubernetes/minikube/issues/new/choose                                                          │
│                                                                                                                          │
│    Please run `minikube logs --file=logs.txt` and attach logs.txt to the GitHub issue.                                   │
│    Please also attach the following file to the GitHub issue:                                                            │
│    - /var/folders/dc/cvsg4_xs3hv5r7hrthj402s400h78j/T/minikube_license_e85b82585dc227c696be066175f114c59335f346_0.log    │
│                                                                                                                          │
╰──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────╯

After (trying with a directory that doesnt exist)

$ mk license -d /tmp/t74
14:47:58 medya/workspace/minikube
$ ls -lah /tmp/t74/licenses/
total 0
drwxr-xr-x  12 medya  wheel   384B May 22 11:01 .
drwxr-xr-x   3 medya  wheel    96B Jul 30 14:47 ..
drwxr-xr-x   3 medya  wheel    96B May 22 11:01 cel.dev
drwxr-xr-x   3 medya  wheel    96B May 22 11:01 cloud.google.com
drwxr-xr-x  86 medya  wheel   2.7K May 22 11:01 github.com
drwxr-xr-x   5 medya  wheel   160B May 22 11:01 go.opentelemetry.io
drwxr-xr-x   4 medya  wheel   128B May 22 11:01 go.uber.org
drwxr-xr-x   3 medya  wheel    96B May 22 11:01 golang.org
drwxr-xr-x   6 medya  wheel   192B May 22 11:01 google.golang.org
drwxr-xr-x   6 medya  wheel   192B May 22 11:01 gopkg.in
drwxr-xr-x  13 medya  wheel   416B May 22 11:01 k8s.io
drwxr-xr-x   6 medya  wheel   192B May 22 11:01 sigs.k8s.io

closes #21205
closes #21207

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 30, 2025
@k8s-ci-robot k8s-ci-robot requested review from nirs and prezha July 30, 2025 21:33
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 30, 2025
@medyagh
Copy link
Member Author

medyagh commented Jul 30, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jul 30, 2025
@medyagh medyagh changed the title download license from github assets download license from github assets and not fail if dir doesnt exist Jul 30, 2025
@medyagh medyagh changed the title download license from github assets and not fail if dir doesnt exist download license from github assets and not fail if dir doesn't exist Jul 30, 2025
@minikube-pr-bot

This comment has been minimized.

Sign in to view
prezha
prezha reviewed Jul 31, 2025
View reviewed changes
Copy link
Contributor

@prezha prezha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple of nits with suggestions for your consideration

@k8s-ci-robot k8s-ci-robot added the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Aug 1, 2025
@medyagh medyagh changed the title download license from github assets and not fail if dir doesn't exist license: don't fail if output dir doesn't exist & download from github assets first Aug 1, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Aug 1, 2025
@minikube-pr-bot

This comment has been minimized.

Sign in to view
@minikube-pr-bot
Copy link

minikube-pr-bot commented Aug 1, 2025

kvm2 driver with docker runtime

┌────────────────┬──────────┬────────────────────────┐
│    COMMAND     │ MINIKUBE │ MINIKUBE  ( PR 21206 ) │
├────────────────┼──────────┼────────────────────────┤
│ minikube start │ 51.4s    │ 50.7s                  │
│ enable ingress │ 14.6s    │ 15.0s                  │
└────────────────┴──────────┴────────────────────────┘

Times for minikube start: 53.3s 53.0s 49.8s 52.2s 48.7s
Times for minikube (PR 21206) start: 51.5s 48.0s 52.1s 51.0s 51.0s

Times for minikube ingress: 14.5s 14.5s 15.0s 14.5s 14.5s
Times for minikube (PR 21206) ingress: 15.5s 14.5s 14.9s 15.0s 15.0s

docker driver with docker runtime

┌────────────────┬──────────┬────────────────────────┐
│    COMMAND     │ MINIKUBE │ MINIKUBE  ( PR 21206 ) │
├────────────────┼──────────┼────────────────────────┤
│ minikube start │ 24.0s    │ 24.4s                  │
│ enable ingress │ 12.8s    │ 12.8s                  │
└────────────────┴──────────┴────────────────────────┘

Times for minikube start: 23.3s 24.2s 27.1s 21.9s 23.6s
Times for minikube (PR 21206) start: 25.8s 23.6s 23.4s 24.0s 25.4s

Times for minikube (PR 21206) ingress: 10.3s 12.8s 13.8s 13.3s 13.8s
Times for minikube ingress: 13.3s 12.3s 12.3s 13.8s 12.3s

docker driver with containerd runtime

┌───────────────────┬──────────┬────────────────────────┐
│      COMMAND      │ MINIKUBE │ MINIKUBE  ( PR 21206 ) │
├───────────────────┼──────────┼────────────────────────┤
│ minikube start    │ 23.3s    │ 24.2s                  │
│ ⚠️  enable ingress │ 22.7s    │ 29.4s ⚠️                │
└───────────────────┴──────────┴────────────────────────┘

Times for minikube start: 24.2s 24.1s 25.8s 21.7s 20.9s
Times for minikube (PR 21206) start: 21.7s 25.4s 24.5s 24.1s 25.0s

Times for minikube ingress: 22.8s 22.8s 22.8s 22.3s 22.8s
Times for minikube (PR 21206) ingress: 38.8s 22.8s 39.8s 22.8s 22.8s

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Aug 1, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh, prezha

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@medyagh medyagh merged commit 9312911 into kubernetes:master Aug 2, 2025
28 of 37 checks passed
elasticdotventures pushed a commit to elasticdotventures/minikube that referenced this pull request Aug 6, 2025
@medyagh @elasticdotventures
license: don't fail if output dir doesn't exist & download from githu…
720d2fe 
…b assets first (kubernetes#21206)

* copy licenses to gh assests as well

* download licneses from github

* try head first to make code more simple

* remove debug

* fix extra dash

* create license directory if doesnt exist

* Apply suggestion from prezha

* Apply suggestion from prezha

* Apply suggestion from prezha

* Apply suggestion from prezha
pavansaikrishna78 pushed a commit to pavansaikrishna78/minikube that referenced this pull request Aug 11, 2025
@medyagh @pavansaikrishna78
license: don't fail if output dir doesn't exist & download from githu…
81fd1a3 
…b assets first (kubernetes#21206)

* copy licenses to gh assests as well

* download licneses from github

* try head first to make code more simple

* remove debug

* fix extra dash

* create license directory if doesnt exist

* Apply suggestion from prezha

* Apply suggestion from prezha

* Apply suggestion from prezha

* Apply suggestion from prezha
pavansaikrishna78 pushed a commit to pavansaikrishna78/minikube that referenced this pull request Aug 18, 2025
@medyagh @pavansaikrishna78
license: don't fail if output dir doesn't exist & download from githu…
b8fcf6a 
…b assets first (kubernetes#21206)

* copy licenses to gh assests as well

* download licneses from github

* try head first to make code more simple

* remove debug

* fix extra dash

* create license directory if doesnt exist

* Apply suggestion from prezha

* Apply suggestion from prezha

* Apply suggestion from prezha

* Apply suggestion from prezha
pavansaikrishna78 pushed a commit to pavansaikrishna78/minikube that referenced this pull request Sep 9, 2025
@medyagh @pavansaikrishna78
license: don't fail if output dir doesn't exist & download from githu…
4da6c8c 
…b assets first (kubernetes#21206)

* copy licenses to gh assests as well

* download licneses from github

* try head first to make code more simple

* remove debug

* fix extra dash

* create license directory if doesnt exist

* Apply suggestion from prezha

* Apply suggestion from prezha

* Apply suggestion from prezha

* Apply suggestion from prezha
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@prezha prezha prezha approved these changes

@nirs nirs Awaiting requested review from nirs

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

minikube license fails if there dir doesnt exist Move minikube licenses Tar to github assets

4 participants

@medyagh @minikube-pr-bot @k8s-ci-robot @prezha