Skip to content

ui: add more translations for korean #21465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 2, 2025
Merged

ui: add more translations for korean #21465

merged 2 commits into from
Sep 2, 2025
+20 −20

Conversation

@developowl
Copy link
Member

@developowl developowl commented Sep 1, 2025

Description 🥝

Hello. I'm a contributor working on the Korean translation of the Kubernetes website. I recently recognized the need for translation of minikube's ko.json file, and I'm working on it.

I've tried to reflect the original context as much as possible, and I've tried to match the period (.) as closely as possible to the original text. It's over 1,100 lines long, but I'll work on it sequentially, 100 lines at a time. Thank you for your help!

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 1, 2025
@k8s-ci-robot k8s-ci-robot requested review from nirs and prezha September 1, 2025 16:52
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Sep 1, 2025

Welcome @developowl!

It looks like this is your first PR to kubernetes/minikube 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/minikube has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 1, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Sep 1, 2025

Hi @developowl. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 1, 2025
@minikube-bot
Copy link
Collaborator

minikube-bot commented Sep 1, 2025

Can one of the admins verify this patch?

@medyagh medyagh changed the title Add translations for korean L1~100 ui: add more translations for korean Sep 2, 2025
@medyagh
Copy link
Member

medyagh commented Sep 2, 2025

@developowl can you please rebase

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 2, 2025
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 2, 2025
@developowl
Copy link
Member Author

developowl commented Sep 2, 2025

@medyagh I completed the rebase. Thank you!

@developowl
Copy link
Member Author

developowl commented Sep 2, 2025

@medyagh additional, Can you check this issue? 🙏🏻
#21468 issue link

@medyagh
Copy link
Member

medyagh commented Sep 2, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 2, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Sep 2, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: developowl, medyagh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 2, 2025
@medyagh medyagh merged commit af31c00 into kubernetes:master Sep 2, 2025
9 of 11 checks passed
@developowl developowl mentioned this pull request Sep 3, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nirs nirs Awaiting requested review from nirs

@prezha prezha Awaiting requested review from prezha

Assignees

@medyagh medyagh

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@developowl @k8s-ci-robot @minikube-bot @medyagh