verify aux drivers installed correctly and exit nicely if not#21576
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: medyagh The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/ok-to-test |
This comment has been minimized.
This comment has been minimized.
|
|
||
| output, err := exec.Command(path, "version").Output() | ||
| cmd := exec.Command(path, "version") | ||
| output, err := cmd.CombinedOutput() |
There was a problem hiding this comment.
We should not combine stdout and stderr - stdout should be the yaml:
version: xxx
commit: yyystderr can have anything we log in command.
We should use:
out, err := cmd.Output()
if err != nil {
if ee, ok := err.(*exec.ExitError); ok {
stderr = string(ee.Stderr)
}
stderr = ""
}I'm using a helper to get Stderr since this is so common:
https://github.com/nirs/kubectl-gather/blob/6b34fdce4c2ffe83111b2c540a371f788979189e/e2e/commands/commands.go#L34
There was a problem hiding this comment.
that seems like it could be its own Separate PR to update all minikube referneces to that. i prefer if we change this we change it everywhere that would be a bit of an effort, welcome to make that PR
| path, err := exec.LookPath(executable) | ||
| if err != nil { | ||
| return path, err | ||
| klog.Warningf("driver not in path : %s, %v", path, err.Error()) |
There was a problem hiding this comment.
klog.Warningf("driver %q not in path %q: %v", driverName, path, err)
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
/ok-to-test |
|
@medyagh: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/retest-this-please |
|
kvm2 driver with docker runtime DetailsTimes for minikube start: 39.5s 41.8s 39.8s 39.6s 42.0s Times for minikube ingress: 15.8s 15.8s 15.8s 15.8s 15.8s docker driver with docker runtime DetailsTimes for minikube start: 20.6s 22.0s 23.1s 21.3s 20.7s Times for minikube ingress: 10.6s 11.6s 13.6s 10.6s 13.6s docker driver with containerd runtime DetailsTimes for minikube start: 20.1s 19.9s 19.0s 20.2s 21.8s Times for minikube ingress: 23.1s 23.1s 40.1s 29.1s 23.1s |
|
Here are the number of top 10 failed tests in each environments with lowest flake rate.
Besides the following environments also have failed tests:
To see the flake rates of all tests by environment, click here. |
improve user experince for When our aux driver is doesnt run
before this PR
After this PR