Skip to content

Add cgroup v2 freezer check for API server status#22249

Merged
medyagh merged 5 commits intokubernetes:masterfrom
medyagh:kvm_pause_test
Dec 25, 2025
Merged

Add cgroup v2 freezer check for API server status#22249
medyagh merged 5 commits intokubernetes:masterfrom
medyagh:kvm_pause_test

Conversation

@medyagh
Copy link
Copy Markdown
Member

@medyagh medyagh commented Dec 20, 2025 •
edited
Loading

Improve Detecting Pause on Cgroupv2

closes
#22247

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 20, 2025
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Dec 20, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 20, 2025
@medyagh medyagh changed the title Add cgroup v2 freezer check for API server status. wip: Add cgroup v2 freezer check for API server status. Dec 20, 2025
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 20, 2025
@medyagh
Copy link
Copy Markdown
Member Author

medyagh commented Dec 20, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Dec 20, 2025
@minikube-pr-bot

This comment has been minimized.

Sign in to view
@minikube-pr-bot

This comment has been minimized.

Sign in to view
@medyagh medyagh requested a review from Copilot December 22, 2025 20:26
Copilot AI reviewed Dec 22, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves API server pause detection on systems using cgroup v2 by adding a fallback mechanism when the traditional cgroup v1 freezer check fails.

Key Changes:

  • Added isCgroupV2Paused() function to check freeze state using cgroup v2 interface
  • Modified APIServerStatus() to attempt cgroup v2 detection before falling back to non-freezer status checks

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread pkg/minikube/bootstrapper/bsutil/kverify/api_server.go
Comment thread pkg/minikube/bootstrapper/bsutil/kverify/api_server.go Outdated
Comment thread pkg/minikube/bootstrapper/bsutil/kverify/api_server.go
Comment thread pkg/minikube/bootstrapper/bsutil/kverify/api_server.go
Comment thread pkg/minikube/bootstrapper/bsutil/kverify/api_server.go Outdated
medyagh and others added 5 commits December 23, 2025 17:53
@medyagh
Copy link
Copy Markdown
Member Author

medyagh commented Dec 24, 2025

/ok-to-test

@minikube-pr-bot
Copy link
Copy Markdown

minikube-pr-bot commented Dec 24, 2025

kvm2 driver with docker runtime

┌────────────────┬──────────┬────────────────────────┐
│    COMMAND     │ MINIKUBE │ MINIKUBE  ( PR 22249 ) │
├────────────────┼──────────┼────────────────────────┤
│ minikube start │ 42.4s    │ 41.8s                  │
│ enable ingress │ 15.8s    │ 16.1s                  │
└────────────────┴──────────┴────────────────────────┘
Details

Times for minikube start: 43.7s 43.3s 42.5s 42.8s 39.7s
Times for minikube (PR 22249) start: 41.2s 41.9s 44.3s 41.4s 40.3s

Times for minikube ingress: 15.8s 15.8s 15.3s 15.8s 16.3s
Times for minikube (PR 22249) ingress: 15.8s 15.8s 16.8s 16.3s 15.8s

docker driver with docker runtime

┌────────────────┬──────────┬────────────────────────┐
│    COMMAND     │ MINIKUBE │ MINIKUBE  ( PR 22249 ) │
├────────────────┼──────────┼────────────────────────┤
│ minikube start │ 22.3s    │ 22.0s                  │
│ enable ingress │ 23.1s    │ 16.6s                  │
└────────────────┴──────────┴────────────────────────┘
Details

Times for minikube start: 20.7s 23.3s 23.5s 21.3s 22.7s
Times for minikube (PR 22249) start: 21.4s 20.6s 21.7s 24.6s 21.5s

Times for minikube ingress: 10.6s 10.6s 73.1s 10.6s 10.6s
Times for minikube (PR 22249) ingress: 10.6s 10.7s 40.6s 10.6s 10.6s

docker driver with containerd runtime

┌────────────────┬──────────┬────────────────────────┐
│    COMMAND     │ MINIKUBE │ MINIKUBE  ( PR 22249 ) │
├────────────────┼──────────┼────────────────────────┤
│ minikube start │ 20.3s    │ 20.6s                  │
│ enable ingress │ 23.1s    │ 23.1s                  │
└────────────────┴──────────┴────────────────────────┘
Details

Times for minikube start: 19.7s 22.3s 18.8s 21.1s 19.9s
Times for minikube (PR 22249) start: 21.6s 21.2s 22.4s 19.3s 18.6s

Times for minikube ingress: 23.1s 23.1s 23.1s 23.1s 23.1s
Times for minikube (PR 22249) ingress: 23.1s 23.1s 23.1s 23.1s 23.1s

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Dec 24, 2025

@medyagh: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
integration-vfkit-docker-macos-arm 03cab77 link false /test integration-vfkit-docker-macos-arm
integration-docker-containerd-linux-x86 03cab77 link true /test integration-docker-containerd-linux-x86
integration-docker-crio-linux-x86 03cab77 link false /test integration-docker-crio-linux-x86
integration-docker-containerd-linux-arm 03cab77 link false /test integration-docker-containerd-linux-arm
integration-docker-docker-linux-arm 03cab77 link true /test integration-docker-docker-linux-arm
integration-kvm-docker-linux-x86 03cab77 link true /test integration-kvm-docker-linux-x86

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@minikube-pr-bot
Copy link
Copy Markdown

minikube-pr-bot commented Dec 24, 2025

Here are the number of top 10 failed tests in each environments with lowest flake rate.

Environment Test Name Flake Rate

Besides the following environments also have failed tests:

  • Docker_Linux_containerd_arm64: 34 failed (gopogh)

  • Docker_Linux_crio_arm64: 55 failed (gopogh)

  • Docker_Linux_crio: 30 failed (gopogh)

  • KVM_Linux_crio: 1 failed (gopogh)

To see the flake rates of all tests by environment, click here.

@medyagh medyagh changed the title wip: Add cgroup v2 freezer check for API server status. Add cgroup v2 freezer check for API server status Dec 25, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 25, 2025
@medyagh medyagh merged commit 61d439e into kubernetes:master Dec 25, 2025
38 of 54 checks passed
@medyagh medyagh mentioned this pull request Jan 28, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@ComradeProgrammer ComradeProgrammer Awaiting requested review from ComradeProgrammer

@nirs nirs Awaiting requested review from nirs

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@medyagh @k8s-ci-robot @minikube-pr-bot @minikube-bot