ci: add configs needed to push gvisor image to k8s-infra using prow#22406
Conversation
…o all prow image make targets
… and update cloudbuild argument.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: medyagh The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Pull request overview
This PR adds the necessary configuration files to push the gvisor image to k8s-infra using Prow, aligning it with the existing kubernetes-bootcamp image workflow.
Key changes:
- Adds new Prow build target and cloudbuild configuration for automated gvisor image building
- Reorganizes gvisor Dockerfile to
deploy/image/gvisor/directory - Updates Makefile to remove manual push workflow in favor of Prow-based automation
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| hack/update/golang_version/golang_version.go | Updates path reference for gvisor Dockerfile location |
| hack/prow/prow.mk | Adds new Prow target for building and pushing gvisor images, renames kubernetes-bootcamp target for consistency |
| hack/prow/image/kubernetes-bootcamp/cloudbuild.yaml | Updates target name to match renamed Makefile target |
| hack/prow/image/gvisor/cloudbuild.yaml | New cloudbuild configuration for gvisor image builds via Prow |
| deploy/image/gvisor/Dockerfile | New multi-stage Dockerfile for building gvisor addon |
| Makefile | Removes GVISOR_TAG variable and manual push target, updates local build target with new Dockerfile path |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@medyagh: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
#22404
still need to add the config on the test-infra side as well