Skip to content

Fix kicbase image load permission denied by using docker CLI#22787

Open
princebirring wants to merge 1 commit intokubernetes:masterfrom
princebirring:Prince-Birring/minikube-fails-to-pull-kicbase-image-due-to-permis
Open

Fix kicbase image load permission denied by using docker CLI#22787
princebirring wants to merge 1 commit intokubernetes:masterfrom
princebirring:Prince-Birring/minikube-fails-to-pull-kicbase-image-due-to-permis

Conversation

@princebirring
Copy link
Copy Markdown

@princebirring princebirring commented Mar 28, 2026 •
edited
Loading

Summary

  • Replace direct Docker daemon socket access (daemon.Write and daemon.Image from go-containerregistry) with Docker CLI commands (docker load -i, docker image inspect) in pkg/minikube/download/image.go
  • This fixes the "permission denied" error when loading the kicbase image for users who access Docker via sudo wrappers or other privilege-escalation mechanisms
  • Removes the now-unused go-containerregistry/pkg/v1/daemon import

Root Cause

When loading the kicbase image, minikube used daemon.Write() and daemon.Image() from the go-containerregistry library, which connect directly to the Docker socket (/var/run/docker.sock). Users who intentionally restrict direct socket access and use sudo-based Docker wrappers get "permission denied" errors, even though other minikube Docker operations (like docker system info) work fine because they go through the Docker CLI.

Test Plan

  • go build ./pkg/minikube/download/ compiles successfully
  • go test ./pkg/minikube/download/ passes
  • Manual test: run minikube start --driver=docker on a system where Docker requires sudo (user not in docker group, using a docker wrapper script)

Fixes #22780

@k8s-ci-robot k8s-ci-robot added the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Mar 28, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Mar 28, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: princebirring
Once this PR has been reviewed and has the lgtm label, please assign prezha for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Mar 28, 2026

Welcome @princebirring!

It looks like this is your first PR to kubernetes/minikube 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/minikube has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 28, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Mar 28, 2026

Hi @princebirring. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@linux-foundation-easycla
Copy link
Copy Markdown

linux-foundation-easycla bot commented Mar 28, 2026 •
edited
Loading

CLA Signed
The committers listed above are authorized under a signed CLA.

  • ✅ login: princebirring / name: Prince Birring (d7914a8)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Mar 28, 2026
@princebirring
Fix kicbase image load permission denied by using docker CLI
d7914a8 
Replace direct Docker daemon socket access (daemon.Write and
daemon.Image from go-containerregistry) with docker CLI commands
(docker load, docker image inspect) so that users who access docker
via sudo wrappers or other privilege-escalation mechanisms are
supported.
@princebirring princebirring force-pushed the Prince-Birring/minikube-fails-to-pull-kicbase-image-due-to-permis branch from 6aca42d to d7914a8 Compare March 28, 2026 01:38
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Mar 28, 2026
@minikube-bot
Copy link
Copy Markdown
Collaborator

minikube-bot commented Mar 28, 2026

Can one of the admins verify this patch?

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Mar 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ComradeProgrammer ComradeProgrammer Awaiting requested review from ComradeProgrammer

@nirs nirs Awaiting requested review from nirs

Assignees

No one assigned

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Minikube fails to pull kicbase image due to permission denied error on docker.sock

3 participants

@princebirring @k8s-ci-robot @minikube-bot