Skip to content

In-place pod resize docs for 1.34 #51729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 6, 2025
Merged

In-place pod resize docs for 1.34 #51729

merged 3 commits into from
Aug 6, 2025

Conversation

@natasha41575
Copy link
Contributor

@natasha41575 natasha41575 commented Jul 29, 2025 •
edited
Loading

Description

In-place pod resize docs for 1.34:

  • Relaxing the memory limit decrease limitation
  • How to use observedGeneration to track resize requests
  • Resize prioritization logic

Issue

kubernetes/enhancements#1287

Notes

can either replace or be cherry-picked into #51533

@k8s-ci-robot k8s-ci-robot added this to the 1.34 milestone Jul 29, 2025
@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Jul 29, 2025
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 29, 2025
@netlify
Copy link

netlify bot commented Jul 29, 2025 •
edited
Loading

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit 2612fd5
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-io-vnext-staging/deploys/68937a4c41d75d0008174e45

@natasha41575
Copy link
Contributor Author

natasha41575 commented Jul 29, 2025

@tallclair I saw your PR description said something about the metrics, I think metrics are generated automatically in

website/content/en/docs/reference/instrumentation/metrics.md

Line 2548 in 046f957

<div class="metric_name">kubelet_volume_stats_inodes_used</div>
, so I don't think we need to add them ourselves?

@natasha41575
Copy link
Contributor Author

natasha41575 commented Jul 29, 2025

/assign @tallclair

@natasha41575 natasha41575 mentioned this pull request Jul 29, 2025
Closed
4 tasks
@netlify
Copy link

netlify bot commented Jul 29, 2025 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 2612fd5
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-io-main-staging/deploys/68937a4c7dfb9f00070a653b
😎 Deploy Preview https://deploy-preview-51729--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@tallclair
Copy link
Member

tallclair commented Jul 29, 2025

Thanks!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 29, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jul 29, 2025

LGTM label has been added.

Git tree hash: 3df088d764125d66a270e3d370f2f577c8608f5f

@natasha41575 natasha41575 mentioned this pull request Jul 30, 2025
Open
95 tasks
aman4433
aman4433 reviewed Jul 30, 2025
View reviewed changes
@yujen77300
Copy link
Contributor

yujen77300 commented Aug 1, 2025

Hello @natasha41575 👋! I'm reaching out from the Docs team.

Just checking in as we approach Docs Freeze on Wednesday August 6, 2025 18:00 PDT. This documentation appears to still be under review. To meet the Docs Freeze, this PR must have a technical review as well as lgtm and approve labels applied, without any unaddressed comments or concerns from SIG Docs. Thank you!

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 1, 2025
@k8s-ci-robot k8s-ci-robot requested a review from tallclair August 1, 2025 20:11
@natasha41575
Copy link
Contributor Author

natasha41575 commented Aug 1, 2025

Hello @natasha41575 👋! I'm reaching out from the Docs team.

Just checking in as we approach Docs Freeze on Wednesday August 6, 2025 18:00 PDT. This documentation appears to still be under review. To meet the Docs Freeze, this PR must have a technical review as well as lgtm and approve labels applied, without any unaddressed comments or concerns from SIG Docs. Thank you!

Thanks for the reminder. The technical review has already been completed by @tallclair above and all other comments have been addressed. Awaiting review from SIG Docs now.

@yujen77300
Copy link
Contributor

yujen77300 commented Aug 6, 2025

Hi @tengqm @nate-double-u

Technical review has been completed by @tallclair (previously added /lgtm), and all comments have been addressed.
Would you mind reviewing and adding /lgtm and /approve if everything looks good? Docs Freeze is August 6, 2025 18:00 PDT.
Thank you so much! 🙏

@michellengnx
Copy link
Contributor

michellengnx commented Aug 6, 2025

/assign @reylejano

@natasha41575
Copy link
Contributor Author

natasha41575 commented Aug 6, 2025

Please note: I will be offline and unavailable to address comments after 15:00 PDT today.

@natasha41575 natasha41575 requested a review from reylejano August 6, 2025 15:53
@reylejano
Copy link
Member

reylejano commented Aug 6, 2025

/approve

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Aug 6, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: reylejano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 6, 2025
@drewhagen
Copy link
Member

drewhagen commented Aug 6, 2025

Hello @natasha41575 👋!

I'm reaching out on behalf of the Release Docs team.

I notice your comment that you'll be back to address comments after 15:00 PDT today.
A friendly reminder that Docs Freeze is approaching today, at 18:00 PT (that gives less than 3 hours for the following). This documentation PR appears to still be under review. Here's where it currently stands:

  • Needs a technical approval from SIG Autoscaling, Node and/or Scheduling - @tallclair signed off
  • Comments and concerns from SIG Docs (at this moment) seem to be addressed
  • Needs a lgtm label applied
  • Needs an approval label applied

If you wish to include this enhancement in 1.34 but are concerned about meeting the deadline, please consider proactively filing an exception request. Thanks!

cc: @kubernetes/autoscaler-reviewers @kubernetes/sig-node-leads @kubernetes/sig-scheduling-leads FYSA

@tallclair
Copy link
Member

tallclair commented Aug 6, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 6, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Aug 6, 2025

LGTM label has been added.

Git tree hash: 8ad70fb9a43f7f0fe096fed7553af085bc6a9fcc

@k8s-ci-robot k8s-ci-robot merged commit 677b491 into kubernetes:dev-1.34 Aug 6, 2025
6 checks passed
@natasha41575 natasha41575 deleted the ippr-docs branch August 6, 2025 17:51
This was referenced Aug 27, 2025
Closed
Closed
@aman4433 aman4433 mentioned this pull request Sep 9, 2025
Closed
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nate-double-u nate-double-u Awaiting requested review from nate-double-u

@tengqm tengqm Awaiting requested review from tengqm

@tallclair tallclair Awaiting requested review from tallclair

@reylejano reylejano Awaiting requested review from reylejano

1 more reviewer

@aman4433 aman4433 aman4433 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@tallclair tallclair

@reylejano reylejano

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

1.34

Development

Successfully merging this pull request may close these issues.

8 participants

@natasha41575 @tallclair @k8s-ci-robot @yujen77300 @michellengnx @reylejano @drewhagen @aman4433