test(e2e): add assertion to legacy tests#16774

Open

lukidzi wants to merge 30 commits into

kumahq:release-2.14from

lukidzi:add-assertion-legacy-test

lukidzi commented May 27, 2026 •

edited

Loading

Contributor

Motivation

Check if there are NACK in legacy test to know if we introduced a breaking change

Implementation information

Added a NACK check to all e2e tests. In helm upgrade I had to scale down ingress and up after starting to avoid situation that Ingress is spawned with a flag for new config and connects to old CP, that causes errors in listener upgrade

Supporting documentation


          test(e2e): add assertion to legacy tests

4d4f68d

Signed-off-by: Lukasz Dziedziak <lukidzi@gmail.com>

lukidzi added the ci/run-full-matrix label

bartsmykla previously approved these changes

View reviewed changes

lukidzi commented Jun 2, 2026

Contributor Author

We need a new release 2.13.7

lukidzi and others added 3 commits

June 3, 2026 16:41


          Merge branch 'master' into add-assertion-legacy-test

59caa9b


          test(e2e): allow to disable preload postgres image (kumahq#16874)

9c30a41

## Motivation

We preload images before running but it affects some repos that using
this framework on k8s clusters

## Implementation information

Allow to disable preloading images

## Supporting documentation

> Changelog: skip

---------

Signed-off-by: Lukasz Dziedziak <lukidzi@gmail.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>


          chore(deps): bump envoy from 1.38.0 to 1.38.1 (kumahq#16875)

6dc53fb

Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

github-actions Bot commented Jun 5, 2026

Contributor

Reviewer Checklist

🔍 Each of these sections need to be checked by the reviewer of the PR 🔍:
If something doesn't apply please check the box and add a justification if the reason is non obvious.

Is the PR title satisfactory? Is this part of a larger feature and should be grouped using > Changelog?
PR description is clear and complete. It Links to relevant issue as well as docs and UI issues
This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as an image registry)
IPv6 is taken into account (.e.g: no string concatenation of host port)
Tests (Unit test, E2E tests, manual test on universal and k8s)
- Don't forget ci/ labels to run additional/fewer tests
Does this contain a change that needs to be notified to users? In this case, UPGRADE.md should be updated.
Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label)

kumahq Bot and others added 19 commits

June 5, 2026 22:02


          docs(CHANGELOG.md): updating changelog and version files (kumahq#16877)

6e2fe5e

Automated changes by
[create-pull-request](https://github.com/peter-evans/create-pull-request)
GitHub action

Signed-off-by: kumahq[bot] <110050114+kumahq[bot]@users.noreply.github.com>
Co-authored-by: kumahq[bot] <110050114+kumahq[bot]@users.noreply.github.com>


          chore(deps/dev): bump kind from 0.31.0 to 0.32.0 (kumahq#16899)

73c98b7

Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>


          chore(deps): bump kindest/node from 1.35.1 to 1.36.1 (kumahq#16898)

9ca1ddd

Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>


          chore(deps): bump jdx/mise-action from 4.0.1 to 4.1.0 (kumahq#16897)

f3470ff

Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>


          chore(deps): bump github.com/spiffe/go-spiffe/v2 from 2.6.0 to 2.7.0 (k…

20c5f4c

…umahq#16896)

Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>


          chore(deps): bump github.com/jackc/pgx/v5 from 5.9.2 to 5.10.0 (kumah…

75927a8

…q#16895)

Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>


          chore(deps/dev): bump yq from 4.53.2 to 4.53.3 (kumahq#16894)

6a3ad7f

Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>


          chore(deps/dev): bump npm:@redocly/cli from 2.31.2 to 2.31.4 (kumahq#…

50c4405

…16892)

Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>


          chore(deps): bump kumactl install demo|observability images from 13.0…

efd0a4f

….1 to 13.0.2 (kumahq#16891)

Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>


          chore(deps): bump Kong/public-shared-actions/security-actions/sign-do…

e44bca2

…cker-image from 5.0.3 to 5.0.4 (kumahq#16890)

Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>


          chore(deps): bump Kong/public-shared-actions/security-actions/scan-do…

be2ae0f

…cker-image from 6.1.0 to 6.1.1 (kumahq#16889)

Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>


          chore(deps): bump go version from 1.26.3 to 1.26.4 (kumahq#16888)

c786e2e

Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>


          chore(deps): bump github/codeql-action from 4.36.0 to 4.36.2 (kumahq#…

1dc39a8

…16887)

Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>


          chore(deps): bump github.com/prometheus/common from 0.68.0 to 0.68.1 (k…

93692df

…umahq#16886)

Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>


          chore(deps): bump golang.org/x/exp from c761662 to 055de63 (kumahq#16883

e1a1c06

)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [golang.org/x/exp](https://pkg.go.dev/golang.org/x/exp) | require |
digest | `c761662` → `055de63` |

---

> [!WARNING]
> Some dependencies could not be looked up. Check the [Dependency
Dashboard](..kumahq/issues/12547) for more information.

---

### Configuration

📅 **Schedule**: (UTC)

- Branch creation
  - Between 12:00 AM and 03:59 AM, only on Monday (`* 0-3 * * 1`)
- Automerge
  - At any time (no schedule defined)

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR was generated by [Mend Renovate](https://mend.io/renovate/).
View the [repository job
log](https://developer.mend.io/github/kumahq/kuma).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0My4yMDkuNCIsInVwZGF0ZWRJblZlciI6IjQzLjIwOS40IiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIiwibGFiZWxzIjpbImRlcGVuZGVuY2llcyJdfQ==-->

Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>


          chore(deps): bump k8s.io/kube-openapi from aa012df to 865597e (kumahq…

a21328c

…#16884)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
|
[k8s.io/kube-openapi](https://redirect.github.com/kubernetes/kube-openapi)
| require | digest | `aa012df` → `865597e` |

---

> [!WARNING]
> Some dependencies could not be looked up. Check the [Dependency
Dashboard](..kumahq/issues/12547) for more information.

---

### Configuration

📅 **Schedule**: (UTC)

- Branch creation
  - Between 12:00 AM and 03:59 AM, only on Monday (`* 0-3 * * 1`)
- Automerge
  - At any time (no schedule defined)

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR was generated by [Mend Renovate](https://mend.io/renovate/).
View the [repository job
log](https://developer.mend.io/github/kumahq/kuma).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0My4yMDkuNCIsInVwZGF0ZWRJblZlciI6IjQzLjIwOS40IiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIiwibGFiZWxzIjpbImRlcGVuZGVuY2llcyJdfQ==-->

Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>


          Merge branch 'master' into add-assertion-legacy-test

395b48d


          chore(deps): bump actions/checkout from 6.0.2 to 6.0.3 (kumahq#16885)

8cf219c

Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

fix

12025be

Signed-off-by: Lukasz Dziedziak <lukidzi@gmail.com>

lukidzi dismissed bartsmykla’s stale review via

12025be

June 8, 2026 18:21

lukidzi force-pushed the add-assertion-legacy-test branch from d464fca to 12025be Compare

June 8, 2026 18:21


          add more time to upgrade

fd66097

Signed-off-by: Lukasz Dziedziak <lukidzi@gmail.com>


          Merge branch 'master' into add-assertion-legacy-test

6dff2bf

lukidzi marked this pull request as ready for review

June 10, 2026 10:38

lukidzi requested a review from a team as a code owner

June 10, 2026 10:38

lukidzi requested review from Copilot, lobkovilya and slonka

June 10, 2026 10:38

Copilot started reviewing on behalf of lukidzi

June 10, 2026 10:38


          trigger build

198b41f

Signed-off-by: Lukasz Dziedziak <lukidzi@gmail.com>

Copilot AI reviewed

View reviewed changes

Copilot AI left a comment

Contributor

Pull request overview

Adds control-plane health assertions (including an xDS NACK check) to legacy test/e2e suites to detect breaking changes earlier, and hardens the multizone Helm upgrade test by preventing zone-ingress from running against mixed-version control planes.

Changes:

Added ControlPlaneAssertions(...) to legacy e2e cleanup hooks to fail tests on CP panics/restarts and excessive xDS NACKs.
Updated the multizone Helm upgrade scenario to scale zone-ingress down during upgrade, wait for the upgraded zone CP to reconnect to global, then restart zone-ingress.

Reviewed changes

Copilot reviewed 17 out of 17 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
test/e2e/zoneegress/externalservices/zoneegress_externalservices_hybrid.go	Adds CP assertions during suite cleanup for hybrid zone-egress external services coverage.
test/e2e/webhooks/cert_manager.go	Adds CP assertions during suite cleanup for cert-manager webhook test.
test/e2e/transparentproxy/transparentproxy_configmap_kubernetes.go	Adds CP assertions during suite cleanup for tproxy configmap test.
test/e2e/skipinboundtags/skip_inbound_tags.go	Adds CP assertions during suite cleanup for skip-inbound-tags scenario.
test/e2e/resilience/resilience_multizone_k8s.go	Adds CP assertions during suite cleanup for multizone resilience test.
test/e2e/reachableservices/auto_reachable_services_k8s.go	Adds CP assertions during suite cleanup for auto reachable services test.
test/e2e/reachableservices/auto_reachable_mesh_services_k8s.go	Adds CP assertions during suite cleanup for auto reachable mesh services test.
test/e2e/helm/kuma_helm_upgrade_multizone.go	Adds per-test CP assertions and prevents mixed-version zone-ingress during Helm upgrade by scaling down/up with sync wait.
test/e2e/helm/kuma_helm_deploy_global_zone.go	Adds CP assertions during suite cleanup for Helm global+zone deploy test.
test/e2e/helm/kuma_helm_deploy_global_universal_mode_and_zone.go	Adds CP assertions during suite cleanup for Helm global+zone (universal mode) deploy test.
test/e2e/helm/kuma_helm_deploy_global_and_zone_universal_mode.go	Adds CP assertions during suite cleanup for Helm deploy of global+zone in universal mode.
test/e2e/federation/federation_universal.go	Adds CP assertions during suite cleanup for federation (universal) scenario.
test/e2e/federation/federation_kubernetes.go	Adds CP assertions during suite cleanup for federation (kubernetes) scenario.
test/e2e/externalservices/locality_multizone_hybrid.go	Adds CP assertions during suite cleanup for locality-aware LB external services scenario.
test/e2e/compatibility/cp_compatibility_kubernetes_multizone.go	Adds CP assertions to deferred cleanups for multizone CP compatibility coverage.
test/e2e/cni/taint_controller_race.go	Adds CP assertions during per-test cleanup for the CNI taint controller race test.
test/e2e/bootstrap/corefile_template.go	Adds CP assertions during suite cleanup for CoreDNS corefile template bootstrap test.

test/e2e/externalservices/locality_multizone_hybrid.go Outdated


          Potential fix for pull request finding

03a8542

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Lukasz Dziedziak <lukidzi@gmail.com>

lukidzi changed the base branch from master to release-2.14

June 10, 2026 16:54

lukidzi added 3 commits

June 10, 2026 11:55


          Merge branch 'release-2.14' into add-assertion-legacy-test

dec26ed


          revert master changes

e6664fe

Signed-off-by: Lukasz Dziedziak <lukidzi@gmail.com>

fix

2473b05

Signed-off-by: Lukasz Dziedziak <lukidzi@gmail.com>

lukidzi added the release-2.14 label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

bartsmykla bartsmykla left review comments

slonka Awaiting requested review from slonka slonka is a code owner automatically assigned from kumahq/kuma-maintainers

lobkovilya Awaiting requested review from lobkovilya lobkovilya is a code owner automatically assigned from kumahq/kuma-maintainers

At least 1 approving review is required to merge this pull request.

Labels

ci/run-full-matrix release-2.14