Skip to content

fix(meshaccesslog): deduplicate access logs for shared inbound port (backport of #16374)#16381

Merged
lobkovilya merged 2 commits into
release-2.13from
chore/backport-release-2.13-16374
Apr 24, 2026
Merged

fix(meshaccesslog): deduplicate access logs for shared inbound port (backport of #16374)#16381
lobkovilya merged 2 commits into
release-2.13from
chore/backport-release-2.13-16374

Conversation

@lobkovilya
Copy link
Copy Markdown
Contributor

Manual cherry-pick of #16374 for branch release-2.13

…16374)

When a Kubernetes pod exposes multiple services on the same port (e.g.,
stable + canary), the dataplane spec contains multiple inbound entries
with the same `IP:port`. `MeshAccessLog` iterated over all inbounds and
called `configureListener` on the same listener pointer for each match,
appending access log entries repeatedly. `applyToInbounds` now tracks
configured listener keys and skips duplicates.

- `applyToInbounds`: skip inbounds that map to an already-configured
listener
  - Added a regression test with two inbounds sharing the same port

Signed-off-by: Lukasz Dziedziak <lukidzi@gmail.com>
@lobkovilya lobkovilya requested a review from a team as a code owner April 24, 2026 09:53
@lobkovilya lobkovilya requested review from lukidzi and slonka April 24, 2026 09:53
@lobkovilya lobkovilya changed the title fix(meshaccesslog): deduplicate access logs for shared inbound port (backport of #16374) fix(meshaccesslog): deduplicate access logs for shared inbound port (backport of #16374) Apr 24, 2026
@github-actions
Copy link
Copy Markdown
Contributor

Reviewer Checklist

🔍 Each of these sections need to be checked by the reviewer of the PR 🔍:
If something doesn't apply please check the box and add a justification if the reason is non obvious.

  • Is the PR title satisfactory? Is this part of a larger feature and should be grouped using > Changelog?
  • PR description is clear and complete. It Links to relevant issue as well as docs and UI issues
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as an image registry)
  • IPv6 is taken into account (.e.g: no string concatenation of host port)
  • Tests (Unit test, E2E tests, manual test on universal and k8s)
    • Don't forget ci/ labels to run additional/fewer tests
  • Does this contain a change that needs to be notified to users? In this case, UPGRADE.md should be updated.
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label)

Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
@lobkovilya lobkovilya merged commit 3ec2052 into release-2.13 Apr 24, 2026
15 checks passed
@lobkovilya lobkovilya deleted the chore/backport-release-2.13-16374 branch April 24, 2026 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants