fix(cliproxy): improve remote proxy error messages #162
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the root cause of "fetch failed" errors and improves UX for remote proxy configuration:
Changes
ui/src/pages/settings.tsxhandleTestConnection()now accepts params with current display valuesSettingsPageto persist across tab switchesProxyContentPropsinterface to pass state and setterssrc/cliproxy/remote-proxy-client.tsDNS_FAILEDandNETWORK_UNREACHABLEerror codesmapErrorToCode()to detect DNS and network errorstests/unit/cliproxy/remote-proxy-client.test.tsRoot Cause
The original bug: user types in Host/Port fields, clicks "Test Connection" without blurring → the function used
proxyConfig.remote(persisted values) instead of current input values (displayHost,displayPort).Test Plan
Related Issues