dmq: Fix DNS resolution corruption when search list is used #4536
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-Submission Checklist
in
doc/subfolder, the README file is autogenerated)Type Of Change
Checklist:
Description
When
dns_use_search_list=1(the default),get_record()may prepend a "fake CNAME" record to map short hostnames to their expanded form. The DMQ module'sget_dmq_host_list()function was iterating through all returned records and castingrdatatostruct a_rdata *without checking the record type. This caused CNAME record data (hostname bytes) to be interpreted as IP address bytes, resulting in bogus IP addresses.For example, a hostname containing
.ordwould produce the IP43.111.114.100(the ASCII bytes+ord= 0x2B 0x6F 0x72 0x64).This has been tested and fixed with Kamailio 6.0.x, backported also to master.
Fix
Add a type check to skip non-A records in the iteration loop:
Affected Environments
This bug affects Kamailio deployments using the following setup:
Workarounds
Before this fix, users could work around the issue by: