Allow attribute transformations in SELECT clause#23
Closed
khageshpatel wants to merge 2 commits into
Closed
Conversation
fixed an error introuced while linting
Closed
Owner
|
For #17. |
Owner
|
I've tested this and it works pretty well; some minor problems (like I'm going to play around with the code and see if I can add support for WHERE attributes as well as clean-up the logic a little bit. |
Owner
|
An update on this: I thought it'd be a better idea to build this against the new parser structure (introduced in feature/subquery), so I've made some changes and pushed those to feature/attribute-modifiers. I plan to work on this feature in that branch. Feel free to submit more work to that branch, should you have anything to add! |
Contributor
Author
|
@kshvmdn Thanks |
Owner
|
Merged in 09ea293, thanks @khageshpatel! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements transformation on attributes. Currently only implements format(size,'kb'/'mb'/'gb'), upper, fullpath but other functions can easily be added. Example query:
fsql "select format(size,'kb'), upper(fullpath(name)) from ."