Skip to content

Add audio/video events to EventKind enum#297

Merged
geotre merged 1 commit into
karaxnim:masterfrom
Infinoid:audio-video-events
Apr 10, 2025
Merged

Add audio/video events to EventKind enum#297
geotre merged 1 commit into
karaxnim:masterfrom
Infinoid:audio-video-events

Conversation

@Infinoid

Copy link
Copy Markdown
Contributor

Add events from mozilla's documentation for the <audio> and <video> tags, here and here.

Fixes: #295

@Infinoid

Copy link
Copy Markdown
Contributor Author

I ran nimble test using nim 2.2.2, and got a bunch of warnings, but it ended with

   Success: Execution finished
   Success: All tests passed

@geotre

geotre commented Apr 10, 2025

Copy link
Copy Markdown
Collaborator

That was quick! Looks great, nice job

@geotre geotre merged commit 671b63f into karaxnim:master Apr 10, 2025
@Infinoid

Copy link
Copy Markdown
Contributor Author

That was quick!

copy and paste ftw!

@Infinoid Infinoid deleted the audio-video-events branch April 10, 2025 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

events missing for audio and video tags

2 participants