chore: add unit tests(jest)#174
Draft
aladdin-add wants to merge 2 commits into
Draft
Conversation
for testing some public API
Contributor
|
jest seems like an good solution, but maybe easier if you extend existing test runner to do the same things as Jest? Same functionality? |
Collaborator
Author
|
but the current test cli was not to be a general testing framework, it was only to test the snapshots for kataw. |
Contributor
|
can it be re-factored? |
Collaborator
Author
|
oc, it can be. but I did not see its value - to rewrite the functionality that jest/mocha has been implemented. IMHO, a more reasonable way is to deprecate the test cli, migrate to jest/mocha snapshots. |
Contributor
|
the whole point with kataw is not to depend 3rd libs in the end. deprecating isn't an option |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
todo: add jest coverage