fix: guard nil pointer dereference in customScalingStrategy.GetEffectiveMaxScale#7817
Open
Fedosin wants to merge 1 commit into
Open
fix: guard nil pointer dereference in customScalingStrategy.GetEffectiveMaxScale#7817Fedosin wants to merge 1 commit into
Fedosin wants to merge 1 commit into
Conversation
…iveMaxScale When a ScaledJob uses custom scaling strategy but omits customScalingQueueLengthDeduction (valid since the field is *int32 with omitempty), the controller panics on nil dereference. Add nil guards for both pointer fields, treating nil as zero. Add a regression test that exercises the nil deduction path. Fixes kedacore#7798 Signed-off-by: Mikhail Fedosin <mfedosin@redhat.com>
|
Thank you for your contribution! 🙏 Please understand that we will do our best to review your PR and give you feedback as soon as possible, but please bear with us if it takes a little longer as expected. While you are waiting, make sure to:
Once the initial tests are successful, a KEDA member will ensure that the e2e tests are run. Once the e2e tests have been successfully completed, the PR may be merged at a later date. Please be patient. Learn more about our contribution guide. |
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
customScalingStrategy.GetEffectiveMaxScaleunconditionally dereferencesCustomScalingQueueLengthDeduction(*int32) without a nil guard. The field is declared withomitemptyin the CRD spec, so it isnilwhenever aScaledJobis created withscalingStrategy.strategy: customandcustomScalingRunningJobPercentageset, butcustomScalingQueueLengthDeductionomitted. When the controller reaches the replica calculation path, it panics.This PR adds nil guards for both pointer fields in
GetEffectiveMaxScale, treatingnilas zero (consistent with how other optional fields are handled). A regression test is included that exercises the exact configuration that triggers the panic.Checklist
make generate-scalers-schemahas been run to update any outdated generated filesFixes #7798
Relates to #