Downgrade the react-query version to fix the staleTime not work issue. #135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Thanks! Could you open an issue on react-query? Maybe this is a bug they could fix. That way we could stay on the latest version. |
Author
|
Yes, I plan to open a new issue on react-query, but it will take some time to write a simpler demo to describe the problem. |
Owner
|
I'll wait until we hear back from them on this. Thanks! |
kentcdodds
approved these changes
Jan 4, 2021
Owner
kentcdodds
left a comment
There was a problem hiding this comment.
Thanks, looks like the react-query team isn't planning on fixing this in v2 so we'll lock this to v2.1.1.
Owner
|
Drat, merge conflict. I'll do this myself. Thanks though! @all-contributors please add @cxc421 for code |
Contributor
|
I've put up a pull request to add @cxc421! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After testing different versions of the
react-query, it seems that this issue has appeared since version2.2.0, so a quick fix is downward the related packages to an older version. I've executed the "npm audit" to this change and did not find any vulnerable packages.