Add StorageAccountFirewall option to control storage account network access #62
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the
StorageAccountFirewalloption to allow users to configure whether storage accounts have public or private networking access.Changes Made
Core Implementation
storageAccountFirewallparameter with@allowed(['public', 'private'])validation and default value of'private'publicNetworkAccess: storageAccountFirewall == 'public' ? 'Enabled' : 'Disabled'StorageAccountFirewallparameter to:Invoke-AzBootstrap.ps1Add-AzBootstrapEnvironment.ps1New-AzBicepDeployment.ps1Parameter Resolution Logic
Implements the priority order specified in the issue:
~/.azbootstrap-globals.jsoncfor"storageAccountFirewall"setting-StorageAccountFirewallparameter if provided"private"for securityInteractive Mode Support
[private/public, default: private]Configuration Examples
Global config file (
~/.azbootstrap-globals.jsonc):{ "storageAccountFirewall": "private", "defaultLocation": "eastus" }Command line usage:
Testing
"public"and"private"values are acceptedDocumentation
Security Considerations
The default value is
"private"to ensure storage accounts are created with restricted network access by default, requiring explicit opt-in for public access.Fixes #61.
Warning
Firewall rules blocked me from connecting to one or more addresses
I tried to connect to the following addresses, but was blocked by firewall rules:
aka.msbicep build templates/environment-infra.bicep --stdout(dns block)If you need me to access, download, or install something from one of these locations, you can either:
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.