Skip to content

fix: only redraw on the first char that invalid the search#93

Draft
phanen wants to merge 1 commit into
kevinhwang91:mainfrom
phanen:fix-redraw-3
Draft

fix: only redraw on the first char that invalid the search#93
phanen wants to merge 1 commit into
kevinhwang91:mainfrom
phanen:fix-redraw-3

Conversation

@phanen

@phanen phanen commented Nov 13, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

In this case we also need to avoid redraw:

nvim --clean --cmd "se rtp^=." +"lua require('hlslens').setup()" lua/hlslens/cmdline/init.lua \
  +'lua vim.defer_fn(function() vim.api.nvim_input("/false" .. ("<c-g>"):rep(10) .. "<left>" ) end, 100)'
# then type `....`

to avoid flicker in #91 (comment) and and fix stale hl in #88

@phanen

phanen commented Nov 13, 2025

Copy link
Copy Markdown
Contributor Author

The real issue in #88 is hl is stale when we type the first char that invalid the search, rather than only <c-w>

@phanen phanen marked this pull request as draft November 13, 2025 03:19
@phanen

phanen commented Nov 13, 2025

Copy link
Copy Markdown
Contributor Author

mark this as draft now cause other edge case exist. this is way more complex that I thought before, maybe have to bisect upsteram which commit introduce the redraw bug again. Maybe I will do it next time.. to know what's the actual causing this.

It's not a big deal since this don't have much different on usage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@phanen