refactor(common): split KMX+ binary format from in-memory representation 🔱 #14905
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
Base automatically changed from
feat/common/kmx-plus-osk-flag-in-header
to
epic/embed-osk-in-kmx
October 13, 2025 12:43
Split kmx-plus.ts into two files, so that the in-memory parsed representation of the file can be maintained separately from the binary structures, which need to maintain version metadata. This refactor makes no functional changes. Test-bot: skip Build-bot: build
6aa7561 to
9406e16
Compare
…upport-to-kmx-plus
ermshiperete
approved these changes
Oct 17, 2025
Contributor
ermshiperete
left a comment
There was a problem hiding this comment.
LGTM.
It might be good to add a comment to the file or class headers that mentions the purpose of this file/class (file vs in-memory) - right now it's not obvious why we have two almost identical classes...
Build-bot: skip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split kmx-plus.ts into two files, so that the in-memory parsed representation of the file can be maintained separately from the binary structures, which need to maintain version metadata.
This refactor makes no functional changes.
Test-bot: skip
Build-bot: build