refactor(developer): rename layr.lists to layr.forms 🔱 #15142
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The name `form` better represents the semantic meaning of the structure, and reduces confusion with the `list` section and other uses of `list` in KMX+. Test-bot: skip
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
ermshiperete
approved these changes
Nov 13, 2025
Contributor
ermshiperete
left a comment
There was a problem hiding this comment.
I can see that using form instead of list is better, but I'm still struggling with that term, probably because form has so many different meanings. It's not obvious what's meant with it. Would one of hardware form, hardware, kind, category be better?
developer/src/common/web/utils/src/types/kmx/kmx-plus-builder/build-layr.ts
Outdated
Show resolved
Hide resolved
developer/src/common/web/utils/src/types/kmx/kmx-plus-builder/build-layr.ts
Outdated
Show resolved
Hide resolved
Member
Author
I'm using the terminology from the spec, https://unicode.org/reports/tr35/tr35-keyboards.html#element-layers, where it talks about "This element contains a set of layer elements with a specific physical form factor, whether hardware or touch layout." So agree that 'form' has multiple meanings, but at least this lines up with the spec 😁 |
Co-authored-by: Eberhard Beilharz <ermshiperete@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The name
formbetter represents the semantic meaning of the structure, and reduces confusion with thelistsection and other uses oflistin KMX+.Test-bot: skip