Skip to content

Allow a partial import to overwrite the default role#15215

Merged
pedroigor merged 1 commit intokeycloak:mainfrom
ahus1:is-9891-allow-partial-import-to-overwrite-default-role
Nov 1, 2022
Merged

Allow a partial import to overwrite the default role#15215
pedroigor merged 1 commit intokeycloak:mainfrom
ahus1:is-9891-allow-partial-import-to-overwrite-default-role

Conversation

@ahus1
Copy link
Member

@ahus1 ahus1 commented Oct 28, 2022

When a new role overwrites the old default role by name, the new role takes the old role's place as the default role.

Closes #9891

@ahus1 ahus1 self-assigned this Oct 28, 2022
@ahus1 ahus1 force-pushed the is-9891-allow-partial-import-to-overwrite-default-role branch from adee535 to 27156d6 Compare November 1, 2022 10:51
@ahus1 ahus1 marked this pull request as ready for review November 1, 2022 15:46
@ahus1
Copy link
Member Author

ahus1 commented Nov 1, 2022

@vramik - I see you've been involved in the default roles rewrite, and I wonder if you could review this one. If not (due to time or knowledge), please let me know.

@ahus1 ahus1 requested a review from vramik November 1, 2022 15:47
Copy link
Contributor

@vramik vramik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @ahus1 for the fix!

@ahus1 ahus1 added status/ready area/storage Indicates an issue that touches storage (change in data layout or data manipulation) labels Nov 1, 2022
@pedroigor pedroigor merged commit dd5a60c into keycloak:main Nov 1, 2022
@ahus1 ahus1 deleted the is-9891-allow-partial-import-to-overwrite-default-role branch November 23, 2022 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/storage Indicates an issue that touches storage (change in data layout or data manipulation)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NullPointerException when importing a json

3 participants