Conversation
@ahus1 Thank you for the review and the changes! I have merged your PR. Should I squash the commits so that we have only one commit? |
ahus1
left a comment
There was a problem hiding this comment.
Thank you for reviewing the test case and providing this PR in the first place. All tests are green, and it now ready to be merged.
Generally speaking, you're on the safe side to merge the commits before the final review, especially when they are related like in this case. It might make it simpler and more straightforward for a review and a maintainer in the process. A maintainer can also squash the changes via the GitHub API (what I did in this case) if they feel this is the appropriate thing to do. Overall it is for the maintainer to make sure that the commit log is meaningful to read and all changes can be tracked to their issues and related pull requests. Thank you again for this contribution - the parent issue had already several votes, and I assume even more subscribers. It will be part of Keycloak 23 once it is released. If you want to give it a try, the next nightly release of Keycloak will contain your change. |
* Review comments to add a test, update the API description and adjust the map storage. Closes keycloak#19348 Co-authored-by: Alexander Schwartz <aschwart@redhat.com> (cherry picked from commit dffa7a3)
Closes #19348
Apply the same sorting to subgroups as the sorting of the top level groups.