Run the Vite dev server through the Keycloak server#27311
Merged
Conversation
edewit
previously approved these changes
Mar 1, 2024
agagancarczyk
previously approved these changes
Apr 4, 2024
c6559ff to
902f456
Compare
902f456 to
d37117b
Compare
This was referenced Apr 30, 2024
d37117b to
5500c71
Compare
5500c71 to
dc795a8
Compare
dc795a8 to
3cb911d
Compare
pedroigor
previously approved these changes
Jun 11, 2024
vmuzikar
reviewed
Jun 11, 2024
I seem to be reviewing an old version. Will re-review once the tests pass again.
vmuzikar
previously approved these changes
Jun 11, 2024
edewit
previously approved these changes
Jun 12, 2024
Contributor
|
@jonkoops Build seems to be failing, though. Can you please check it? |
Signed-off-by: Jon Koops <jonkoops@gmail.com>
a65d6b3 to
76df0eb
Compare
edewit
approved these changes
Jun 12, 2024
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes the development experience for the Admin and Account consoles, so that the applications are served by the Keycloak server directly, which then proxies to the Vite server during development only. This unifies how the the applications are served in production and development, mitigating the need to keep special conditions around during testing.
This PR follows the guidelines from the Vite documentation on custom backend integration, with a couple of slight tweaks specific to our setup.
Closes #19750
Closes #28643
Closes #30115